Repository navigation
Assess and improve accessibility - #550
kumaradityaraj wants to merge 5 commits into
Conversation
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
There was a problem hiding this comment.
🟡 Changes recommended
Accessibility issues remain: identical consecutive action results are not re-announced, and invalid-node badges lack a screen-reader-accessible text alternative.
2 open issues
What changed in this PR
This PR improves accessibility across the embeddable workflow editors and language service, addressing part of the accessibility work tracked in #234.
Changes:
- Adds a configurable accessible name and enables Monaco accessibility support.
- Adds polite copy/export status announcements and localized result messages.
- Hides icons from assistive technology and adds plain-text documentation to the Hello World completion.
| File | Description |
|---|---|
packages/text-editor/src/TextEditor.tsx |
Configures Monaco accessibility and accessible-name updates. |
packages/open-workflow-diagram-editor/src/side-panel/WorkflowActions.tsx |
Adds status announcements and hides action icons. |
packages/open-workflow-diagram-editor/src/side-panel/ErrorsSection.tsx |
Marks the error-section icon as decorative. |
packages/open-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx |
Hides node and error-badge icons from assistive technology. |
packages/open-workflow-diagram-editor/src/i18n/locales/en.ts |
Adds English copy/export result messages. |
packages/language-service/src/volar/hello-world.ts |
Adds plain-text completion documentation. |
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The error badge’s accessibility message reads directly from the English dictionary instead of the active translation provider, preventing it from following the selected locale.
1 open issue
2 resolved since last review
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Human assessment is needed because tests do not cover action announcements, repeated-result behavior, or Monaco accessibility settings and label updates, leaving accessibility regressions undetected.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
| model, | ||
| readOnly: isReadOnly, | ||
| ariaLabel, | ||
| accessibilitySupport: "on", |
There was a problem hiding this comment.
I dont think this should be set to on, I see there is an auto option which is the default as it should detect browser settings, we dont want to turn it on for people who dont want it. I would remove it


closes #234
Summary