Skip to content

Assess and improve accessibility - #550

Open
kumaradityaraj wants to merge 5 commits into
open-workflow-specification:mainfrom
kumaradityaraj:accessibility
Open

kumaradityaraj wants to merge 5 commits into
open-workflow-specification:mainfrom
kumaradityaraj:accessibility

Conversation

@kumaradityaraj

Copy link
Copy Markdown
Contributor

closes #234

Summary

  • Add a plain text description to the Hello World completion so editor clients can provide more context.
  • Announce copy and export success or failure messages through a polite live region.
  • Mark node, error, and export icons as decorative for assistive technology.
  • Give the Monaco editor a configurable accessible name and enable its accessibility support.

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 10:20
@netlify

netlify Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d232f37
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6afee4237a26589d4daf70e7
😎 Deploy Preview https://deploy-preview-550--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d232f37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Accessibility issues remain: identical consecutive action results are not re-announced, and invalid-node badges lack a screen-reader-accessible text alternative.

2 open issues
What changed in this PR

This PR improves accessibility across the embeddable workflow editors and language service, addressing part of the accessibility work tracked in #234.

Changes:

  • Adds a configurable accessible name and enables Monaco accessibility support.
  • Adds polite copy/export status announcements and localized result messages.
  • Hides icons from assistive technology and adds plain-text documentation to the Hello World completion.
File Description
packages/​text-editor/​src/​TextEditor.tsx Configures Monaco accessibility and accessible-name updates.
packages/​open-workflow-diagram-editor/​src/​side-panel/​WorkflowActions.tsx Adds status announcements and hides action icons.
packages/​open-workflow-diagram-editor/​src/​side-panel/​ErrorsSection.tsx Marks the error-section icon as decorative.
packages/​open-workflow-diagram-editor/​src/​react-flow/​nodes/​Nodes.tsx Hides node and error-badge icons from assistive technology.
packages/​open-workflow-diagram-editor/​src/​i18n/​locales/​en.ts Adds English copy/export result messages.
packages/​language-service/​src/​volar/​hello-world.ts Adds plain-text completion documentation.

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The error badge’s accessibility message reads directly from the English dictionary instead of the active translation provider, preventing it from following the selected locale.

1 open issue
2 resolved since last review

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because tests do not cover action announcements, repeated-result behavior, or Monaco accessibility settings and label updates, leaving accessibility regressions undetected.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The repeated-copy test can pass without a new announcement because it does not assert the intervening clear-and-repopulate updates needed to detect removal of the status reset.

1 open issue

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 11:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the accessibility improvements across the workflow editors and language service.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

model,
readOnly: isReadOnly,
ariaLabel,
accessibilitySupport: "on",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this should be set to on, I see there is an auto option which is the default as it should detect browser settings, we dont want to turn it on for people who dont want it. I would remove it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Assess and improve accessibility

3 participants