docs(localization): clarify progressive slice delivery - #49
docs(localization): clarify progressive slice delivery#49giodl73-repo wants to merge 15 commits into
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs real behavior proof before merge. Reviewed July 24, 2026, 9:48 AM ET / 13:48 UTC. ClawSweeper reviewWhat this changesThis PR updates RFC 0024 planning documents to describe progressive localization-slice documentation obligations, gate ownership, lifecycle states, and the live implementation ledger. Merge readiness⛔ Blocked until stronger real behavior proof is added - 8 items remain This PR is not already implemented on current main: it adds new RFC 0024 delivery obligations and lifecycle wording. The clarification is useful, but the mandatory inventory, workflow, guidance, and alias requirements need explicit product-direction confirmation because they expand the accepted RFC’s owner-slice contract. Priority: P3 Review scores
Verification
How this fits togetherRFC 0024 defines how localization work moves from bounded owner slices into reviewed runtime and catalog changes. These planning documents guide contributors from a proposed surface through owner review, generated artifacts, and eventual landing in the OpenClaw product repository. flowchart LR
A[Product surface change] --> B[Owner localization slice]
B --> C[Inventory and workflow guidance]
C --> D[Scoped gate review]
D --> E[Source and generated artifacts]
E --> F[Owner approval]
F --> G[Live delivery ledger]
Decision needed
Why: The accepted RFC establishes the localization contract, while this PR changes the operational obligations contributors must satisfy to declare a slice complete; that policy boundary needs maintainer intent rather than documentation inference. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm whether the accepted RFC should require these delivery artifacts for every adopted slice; if approved, retain narrowly scoped wording and attach redacted terminal output or a reproducible validation transcript for the documented checks. Do we have a high-confidence way to reproduce the issue? Not applicable as a runtime bug: the relevant behavior is the proposed RFC wording, which is directly visible in the PR diff and differs from the accepted current-main contract. Is this the best way to solve the issue? No, not without maintainer confirmation. The proposed wording is a reasonable candidate policy, but it should either be explicitly accepted as an RFC contract expansion or constrained to already approved obligations. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against faf2a3a5b1ac. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Pre-merge cleanup is complete at exact head 55b382c: the system diagram is now a vertical 1. Own -> 2. Automate -> 3. Ship summary, and the PR body includes after-change link, slice-ID, diff, Mermaid-render, and semantic-review evidence. Patrick remains requested for the explicit mandatory slice-completion decision. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
The system overview now uses only searchable implementation names from openclaw/openclaw: localization/surfaces.json, localization/catalogs.json, the localization-catalogs CI job, Localization Catalog Refresh, @openclaw/localization-core, and LocalizationContext. RFC planning IDs are absent from the overview and diagram. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
The system diagram now gives every current owner-declared product surface its own box and shows the adoption fan-out explicitly: owner source, localization/surfaces.json, and either localization/catalogs.json, a named conforming owner pipeline, or a reviewed exception rationale. Public workflow guidance and nearest AGENTS.md/CLAUDE.md owner guidance are also shown as same-slice obligations. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Added an exact-head, source-accurate end-to-end example at
Validated the values and registry entries directly against openclaw#112784 / #112801. GitHub Markdown recognizes both Mermaid blocks in the RFC and PR body. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Simplified at exact head The main RFC is now 1,677 words (down from 7,431) and leads with the real wizard string. Reference-level mechanics remain in the normative sidecars. The product target is now unambiguous: English source + 21 translation targets across 15 required surfaces = 315 target cells, and only 315/315 is product-complete. A platform constraint may explain a blocker but no longer reduces the completion target to 313. Validated: clean diff, 6/6 relative links, 47/47 unique slice IDs, both RFC Mermaid blocks recognized, and the example values/registrations asserted against openclaw#112784 and #112801. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Sidecar clarity pass at exact head
Validated 15/15 row-ID parity against @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Made the exemplar event-specific at exact head
This now matches #112784 exactly: PR detection is warning-only for ordinary source drift, generated-path changes run the strict check, and translation/provider/publisher credentials exist only in the trusted post-merge workflow. The implementation plan, coverage state machine, registry, RFC, and PR body use the same description. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Applied a seven-lens
The panel found no remaining architecture contradiction after these fixes. Main RFC remains under 2,000 words, all 15 product surfaces remain visible, both RFC Mermaid blocks and the PR-body Mermaid block render, and claims remain source-backed by #112784/#112801. This role review does not replace Patrick's current-head decision. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Follows accepted RFC #42.
What this clarifies
One string, end to end
The workflow executes generator code from protected
main; the PR registry and English catalogs are validated data only. It never executes PR scripts, actions, dependencies, or hooks with provider credentials. Before pushing, it rechecks open/ready/same-repository/base/head state and uses an exact-head lease. Automation does not approve or merge its output.Delivery
Each owner slice enrolls one bounded surface in the shared gate and refresh workflow, or proves its existing owner pipeline conforms. The 47 projected slices remain grouped into 16 delivery packages toward the September 1, 2026 completion decision. Live delivery stays in openclaw#113105.
Core exemplar: openclaw#112784. Surface registration: openclaw#112801.
Review decision
Project direction and progressive owner onboarding were aligned with Patrick and Vince in Discord. Patrick remains the primary implementation-stack reviewer; semantic, security, platform, and publication owners still review their boundaries.
Validation
Exact head:
0e19881be5a456bfcbf29a81bcc87dbcaf471b08AI-assisted: yes. I reviewed the wording and validation evidence.