Repository navigation
Conversation
edx-platform has had every feature flag as a top-level setting since Ulmo, and the FEATURES dict is being removed along with the FeaturesProxy bridge that kept dict reads working: openedx/openedx-platform#37396 This plugin's settings run during the platform's own settings import and read `settings.FEATURES` there, which fails as soon as the proxy is gone. Set the flat setting instead, deferring to a value the deployment already configured, the way the rest of this file does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
feanil
marked this pull request as ready for review
November 19, 2026 19:32
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edx-platform flattened the
FEATURESdict into top-level settings in Ulmo (openedx/openedx-platform#37067) and is now removing the dict and theFeaturesProxybridge that keptsettings.FEATURESreads working (openedx/openedx-platform#37396).This plugin's
plugin_settingsruns inside the platform's settings import and readssettings.FEATURESthere, so the LMS fails to start as soon as the proxy is gone. It now setsENABLE_DISCUSSION_SERVICEas a flat setting, deferring to a configured value the way the rest of the file does. Behaviour on Ulmo and later is unchanged.