Skip to content

fix: read ENABLE_DISCUSSION_SERVICE as a flat Django setting - #302

Open
feanil wants to merge 1 commit into
openedx:masterfrom
feanil:feanil/features-dict-flat
Open

feanil wants to merge 1 commit into
openedx:masterfrom
feanil:feanil/features-dict-flat

Conversation

@feanil

@feanil feanil commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

edx-platform flattened the FEATURES dict into top-level settings in Ulmo (openedx/openedx-platform#37067) and is now removing the dict and the FeaturesProxy bridge that kept settings.FEATURES reads working (openedx/openedx-platform#37396).

This plugin's plugin_settings runs inside the platform's settings import and reads settings.FEATURES there, so the LMS fails to start as soon as the proxy is gone. It now sets ENABLE_DISCUSSION_SERVICE as a flat setting, deferring to a configured value the way the rest of the file does. Behaviour on Ulmo and later is unchanged.

edx-platform has had every feature flag as a top-level setting since
Ulmo, and the FEATURES dict is being removed along with the FeaturesProxy
bridge that kept dict reads working:
openedx/openedx-platform#37396

This plugin's settings run during the platform's own settings import and
read `settings.FEATURES` there, which fails as soon as the proxy is gone.
Set the flat setting instead, deferring to a value the deployment already
configured, the way the rest of this file does.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant