Repository navigation
fix: send xqueue graders lang, hide_output, and skip_grader - #39396
Merged
feanil merged 1 commit intoNov 19, 2026
Merged
Conversation
Upgrades edx-submissions to 4.1.2 and xblocks-core to 2.0.2 so that the lang, hide_output, and skip_grader keys in a problem's <grader_payload> reach xqueue-watcher again. They were being dropped when the XQueue body was rebuilt from ExternalGraderDetail, which only kept "grader". Losing skip_grader was the worst of it: the watcher would try to grade code the course never meant to run. These releases also make submission_time use XQueue's format, stop sending a hardcoded random_seed, and surface send_to_submission errors to the learner instead of leaving the submission "queued". edx-submissions 4.1.1 adds a migration for the new ExternalGraderDetail fields. xblocks-core is pinned to 2.0.2 rather than 3.0.0, since 3.0.0 removes local CodeJail and is being handled in openedx#39382. See openedx/edx-submissions#390 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@feanil: I'm not really sure what the plan is for the xblocks-core 3.0 codejail update, so please merge or close this as you see fit. |
feanil
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades edx-submissions from 4.1.0 to 4.1.2 and xblocks-core from 2.0.0 to 2.0.2. This fixes openedx/edx-submissions#390.
When the XQueue body was rebuilt from
ExternalGraderDetail, every key in a problem's<grader_payload>exceptgradergot dropped. xqueue-watcher's built-in graders also readlang,hide_output, andskip_grader, so:skip_graderproblems were graded anyway. Learners could get an error and no credit, or stay on "queued" while the watcher kept retrying.hide_outputwas ignored, so learners were shown the expected output from the staff answer.langwas ignored. It only affects strings that course teams translate themselves.What's in these releases:
lang,hide_output, andskip_graderonExternalGraderDetailand puts them back ingrader_payload. Also sendssubmission_timein XQueue's%Y%m%d%H%M%Sformat and stops sending a hardcodedrandom_seed. Includes a migration for the new fields. Their defaults give existing rows the same payload they get today.openedx-eventsas a runtime dependency. The platform already installs it.<grader_payload>and passes them to edx-submissions. Also logs a warning instead of failing when<grader_payload>isn't a JSON object, and shows the learner an error instead of leaving them on "queued" forever whensend_to_submissionfails.This only affects courses that grade through edx-submissions (the
send_to_submission_course.enablewaffle flag), not the legacy XQueue HTTP path. Submissions queued before the migration runs will still go out with onlygrader, since the other keys were never stored.Why not xblocks-core 3.0.0?
3.0.0 is the latest release, but it removes local CodeJail and unsafe execution, which the platform still uses by default. That upgrade is being done in #39382 along with the settings and test changes it needs. 2.0.2 is the release that has this fix.
Supporting information
graderkey of<grader_payload>edx-submissions#390: issue and discussionTesting instructions
send_to_submission_course.enablefor a course that is set up with xqueue-watcher.<grader_payload>is{"grader": "...", "skip_grader": true}and submit an answer.grader_payloadthat the watcher receives should includeskip_grader. With 4.1.0/2.0.0 it only hadgrader.The lockfile was regenerated with
make compile-requirements UV_LOCK_OPTS="--upgrade-package edx-submissions==4.1.2 --upgrade-package xblocks-core==2.0.2", so no other packages change.🤖 Generated with Claude Code