Skip to content

feat: let enrolled learners and course staff read a course run's competency criteria - #39415

Open
tbain wants to merge 6 commits into
openedx:masterfrom
tbain:tbain/733_lms_course_competency_criteria
Open

tbain wants to merge 6 commits into
openedx:masterfrom
tbain:tbain/733_lms_course_competency_criteria

Conversation

@tbain

@tbain tbain commented Nov 20, 2026

Copy link
Copy Markdown

This PR continues Unicon#4, opened by jesperhodge, and carries the same six commits. I am taking over openedx/openedx-core#733, and the earlier review discussion and local verification results are on that PR.

This is one of two PRs that implement openedx/openedx-core#733. The other is openedx/openedx-core#949.

Please read the HTML PR Description:

openedx-platform-4-pr-description-2.html

AI Review

Code Review: review-platform-pr4-cleaned.html

Fix Report: fix-report-platform-pr4.md

jesperhodge and others added 6 commits November 18, 2026 11:06
Mounts openedx-core's learner CBE URL module in the LMS and overrides
openedx_learning.view_course_competency_criteria so that only users with
an active enrollment in the course run, or staff access to it, may read
its competency criteria.

Part of openedx/openedx-core#733

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The content test's course now starts in the past, so the released and
restricted subsections are loadable as controls. The permission's comment
and docstring state the registration rule and where identical results
come from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @tbain!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants