Repository navigation
Conversation
edx-platform has had every feature flag as a top-level setting since Ulmo, and the FEATURES dict is being removed along with the FeaturesProxy bridge that kept dict reads working: openedx/openedx-platform#37396 The video, discussion and html blocks now read their flags with getattr on the flat name, with the same defaults as before. The html block's "to enable" message names the flat setting. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Kelketek
requested changes
Nov 19, 2026
| "FALLBACK_TO_ENGLISH_TRANSCRIPTS": False, | ||
| }, | ||
| ) | ||
| @patch.object(settings, "FALLBACK_TO_ENGLISH_TRANSCRIPTS", create=True, new=False) |
Contributor
There was a problem hiding this comment.
Could this be an @override_settings call instead? That would be more idiomatic.
| }, | ||
| ) | ||
| # The default value in {lms,cms}/envs/common.py and xmodule/tests/test_video.py should be consistent. | ||
| @patch.object(settings, "FALLBACK_TO_ENGLISH_TRANSCRIPTS", create=True, new=True) |
Contributor
There was a problem hiding this comment.
Same question here-- can we use @override_settings?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edx-platform flattened the
FEATURESdict into top-level settings in Ulmo (openedx/openedx-platform#37067) and is now removing the dict and theFeaturesProxybridge that keptsettings.FEATURESreads working (openedx/openedx-platform#37396).The video, discussion and html blocks read their flags with
getattron the flat names now, with the same defaults as before. The html block's "to enable" message names the flat setting. Behaviour on Ulmo and later is unchanged.