Repository navigation
Conversation
feanil
commented
Nov 20, 2026
| return default | ||
|
|
||
|
|
||
| def sanitize_html(html_code): |
Contributor
Author
There was a problem hiding this comment.
MatlabInput was the onlything using this so it and its tests can be removed.
The MATLAB integration sent code to the MathWorks hosted service through the XQueue service and got results back on the XQueue callback URL. Neither exists any more: the service is deprecated and its repo archived (openedx/public-engineering#286), and the LMS now queues submissions in edx-submissions, which has no callback. openedx/public-engineering#192 deprecated the MATLAB handling in 2023 because the endpoint it talked to no longer worked. Remove MatlabInput, its template, fixture and CodeMirror octave mode, the sanitize_html helper only it used, the matlab_api_key field on ProblemBlock and LoncapaSystem, the API key payload in CodeResponse, and the ungraded_response handlers that carried MATLAB's plot output. <matlabinput> stays as a tag on CodeInput so existing problems still parse and learners keep their scores. It renders as a plain code box. BREAKING CHANGE: LoncapaSystem no longer accepts matlab_api_key, and ProblemBlock no longer has that field or the ungraded_response handler. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
XQueueInterface could still post to the XQueue service over HTTP when the send_to_submission_course.enable flag was off for a course, with a login round trip, request timeouts and reply parsing to go with it. The XQueue service is deprecated and its repo archived (openedx/public-engineering#286), and edx-submissions is the only queue the LMS serves, so the HTTP path goes. XQueueInterface now takes the block and hands every submission to XQueueInterfaceSubmission. The header no longer carries a callback URL: scores come back through the EXTERNAL_GRADER_SCORE_SUBMITTED signal, not an HTTP callback. The header is an internal envelope now; edx-submissions reads the queue name and the queue key out of it and builds its own header for the grader. send_to_queue reports a failure inside edx-submissions the way it reported a connection failure to the XQueue service. It catches SubmissionError and XQueueSubmissionError and returns (1, message), so the learner sees an error instead of waiting on a submission that was never queued. It returns 0 on success, as the HTTP path did, where the edx-submissions path returned None. BREAKING CHANGE: XQueueInterface(url, django_auth, requests_auth, block, use_submission_service) is now XQueueInterface(block). make_xheader no longer takes lms_callback_url. The runtime's xqueue service no longer needs construct_callback. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
feanil
force-pushed
the
feanil/remove-legacy-xqueue-matlab
branch
from
November 20, 2026 20:19
2eb406f to
9e40e5e
Compare
feanil
marked this pull request as ready for review
November 20, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XQueue service is deprecated and its repo archived (openedx/public-engineering#286). The LMS queues external grader submissions in edx-submissions and serves the API that xqueue-watcher polls, and scores come back through the
EXTERNAL_GRADER_SCORE_SUBMITTEDsignal. This removes the code that only existed for the old service, and the MATLAB integration that only worked through it (openedx/public-engineering#192).XQueue
XQueueInterfaceno longer posts to the XQueue service over HTTP. The login round trip, the request timeouts,parse_xreplyand theuse_submission_serviceswitch are gone. It now takes the block and hands every submission toXQueueInterfaceSubmission.make_xheaderno longer takeslms_callback_url. Nothing calls back any more.xqueueservice no longer needsconstruct_callback.MATLAB
MatlabInput, its template, fixture and CodeMirror octave mode, and thesanitize_htmlhelper only it used are gone.matlab_api_keyis gone fromProblemBlockandLoncapaSystem, andCodeResponseno longer adds the API key to the grader payload.ungraded_responsehandlers that carried MATLAB's plot output are gone.<matlabinput>stays as a tag onCodeInput, so existing problems still parse and learners keep their scores. It renders as a plain code box.Both commits are
feat!, so this releases as a major version. openedx-platform needs a matching change for the newXQueueInterfacesignature and the droppedLoncapaSystemargument: openedx/openedx-platform#39405. The pin bump and that PR have to land together, since droppingmatlab_api_keyfrom the non-editable list here makes the field editable again in Studio on a platform that still has it on the inheritance mixin.The Python suite passes locally (836 tests). The JS spec that covered polling on a queued problem now uses a codeinput fixture instead of the MATLAB one.