This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Add CORS Max-Age header of 600 seconds - #11819
Open
tbcd wants to merge 1 commit into
Open
Conversation
sorpaas
added
A0-pleasereview 🤓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CORS
Access-Control-Max-Ageof600seconds to RPC pre-flightOPTIONSresponses.Original issue #8542 was closed a year later as being implemented in paritytech/jsonrpc#280, but that was (and still is) disabled by default, so this was never actually resolved.
The value of
600seconds matches Geth's implementation.Fixes #8542.