AGENT-1578: Promote NoRegistryClusterInstall feature to default

[pawanpinjarkar]

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1578 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8fe02349-af41-4b5e-86eb-5a1c43b2484d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Hello @pawanpinjarkar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[pawanpinjarkar]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[sadasu]

@pawanpinjarkar the manual override file https://github.com/openshift/api/blob/release-4.22/machineconfiguration/v1/manual-override-crd-manifests/internalreleaseimages.machineconfiguration.openshift.io/NoRegistryClusterInstall.yaml also needs to removed.

Please use #2859 as reference.

[everettraven]

/test e2e-aws-serial-techpreview-2of2
/test e2e-gcp

hypershift integration is an unrelated failure.

/override-sticky ci/prow/verify-hypershift-integration

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-hypershift-integration

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/test e2e-aws-serial-techpreview-2of2
/test e2e-gcp

hypershift integration is an unrelated failure.

/override-sticky ci/prow/verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sadasu]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

[openshift-ci]

@sadasu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b739ac0-973d-11f1-9047-763292dc9185-0

[everettraven]

/lgtm
/approve

4.22 branch doesn't have feature promotion verification updates for install-time features, but looking at the new Sippy view and filtering out all the things that we would normally filter out, and accounting for a fix to how the jobs run that merged recently (trending green since the fix), this feature looks quite stable to me. Overriding the check.

/override ci/prow/verify-feature-promotion

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-feature-promotion

Details

In response to this:

/lgtm
/approve

4.22 branch doesn't have feature promotion verification updates for install-time features, but looking at the new Sippy view and filtering out all the things that we would normally filter out, and accounting for a fix to how the jobs run that merged recently (trending green since the fix), this feature looks quite stable to me. Overriding the check.

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pawanpinjarkar]

/verified by @pawanpinjarkar

[openshift-ci-robot]

@pawanpinjarkar: This PR has been marked as verified by @pawanpinjarkar.

Details

In response to this:

/verified by @pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/label backport-risk-assessed

[sadasu]

/label backport-risk-assessed

[openshift-ci]

@sadasu: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zaneb]

/label backport-risk-assessed
Will manually add valid-bug as this is subject to an approved SBAR.

[zaneb]

TIL the GitHub UI for labels has race conditions.
/label backport-risk-assessed

[zaneb]

/retest-required

[openshift-ci]

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.