Skip to content

Require confirm-delete annotation for OpenStackDataPlaneDeployment deletion - #2013

Open
rabi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rabi:deployment_delete
Open

Require confirm-delete annotation for OpenStackDataPlaneDeployment deletion#2013
rabi wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rabi:deployment_delete

Conversation

@rabi

@rabi rabi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Deleting a Deployment mid-execution may leave data plane nodes in an inconsistent or unrecoverable state. Require users to set the annotation dataplane.openstack.org/confirm-delete=true before deletion is allowed.

@openshift-ci
openshift-ci Bot requested review from dprince and slagle August 4, 2026 06:59
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 365025 bytes (356KB)
Base branch size 365025 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@rabi
rabi force-pushed the deployment_delete branch 2 times, most recently from 5a542dc to 47374db Compare August 4, 2026 08:22
@rabi

rabi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

/test precommit-check

…letion

Deleting a Deployment mid-execution may leave data plane nodes in an
inconsistent or unrecoverable state. Require users to set the annotation
dataplane.openstack.org/confirm-delete=true before deletion is allowed.

Signed-off-by: rabi <ramishra@redhat.com>
@rabi
rabi force-pushed the deployment_delete branch from 47374db to 2b21291 Compare August 4, 2026 12:06
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@rabi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-20 2b21291 link true /test openstack-operator-build-deploy-kuttl-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant