Repository navigation
Conversation
The CI of this repository does not run Infrahub's own tests, which use the SDK from the python_sdk submodule. A rule for files under infrahub_sdk/ asks the agent to suggest a draft, do-not-merge pull request in opsmill/infrahub before such a change is merged, and a guide lists the steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
saltas888
added
type/housekeeping
Deploying infrahub-sdk-python with
|
| Latest commit: |
b8fa1ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d00ebdf4.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://ds-agents-infrahub-ci-check.infrahub-sdk-python.pages.dev |
saltas888
marked this pull request as ready for review
October 16, 2026 15:01
The guide's gh pr create command had no body, so it failed outside a terminal. The up-to-date check read the submodule HEAD instead of the pinned commit, and the rule for other base branches matched Infrahub stable for every SDK branch. The rule now also loads for pyproject.toml, whose dependencies Infrahub resolves, and AGENTS.md keeps only the ask-first entry so the when-to-suggest text lives in the rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gmazoyer
reviewed
Oct 20, 2026
Comment on lines
+48
to
+52
| ## Read the results | ||
|
|
||
| - Compare a failing job with the latest run of the same job on the Infrahub branch. A job that also fails there is not caused by the SDK change. | ||
| - Link the Infrahub pull request from the SDK pull request, with the result. | ||
| - Close the Infrahub pull request and delete its branch when you are done. It is never merged: SDK releases reach Infrahub through Infrahub's submodule update workflow. |
Contributor
There was a problem hiding this comment.
In the CI, a failed light check fails huge-runner-gate. The gate then skips the component, integration and functional backend jobs. A pointer-only PR can trip this, for example when the SDK change modifies InfrahubRepositoryConfig. Then dotinfrahub.mdx is stale and validate-generated-documentation fails. Could you add a line to say that a skipped backend job is not a pass, and to check huge-runner-gate also?
Contributor
Author
There was a problem hiding this comment.
good catch. adjusting.
…sults Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Docs only:
The CI of this repository runs the SDK unit tests, and integration tests against an Infrahub image started by
infrahub-testcontainers. It does not run Infrahub's own tests, which use the SDK from thepython_sdksubmodule, so a change to code that Infrahub calls can pass here and still break Infrahub. Running Infrahub's CI against the SDK branch finds this before the merge: a draft pull request inopsmill/infrahubthat only moves the submodule. This came up on #1423.