Provision the E2E NetBox with docker compose

[ideaship]

Part of the series tracked in #2562, which explains the ordering and what each PR covers. Based on the preceding PR in the stack, so review only the top commits here.

The infrastructure: compose.yaml (Postgres, Valkey, NetBox), deploy_netbox.sh
to bring it up and mint an API token, sonic_golden_test.sh as the harness
entry point, and the make sonic-e2e* targets.

Two decisions worth knowing while reading it:

Only NETBOX_PORT is interpolated into the compose file. Compose
re-interpolates the whole file on every subcommand, not just up, so
${VAR:?} guards would break down, ps and logs too. The rest of the
configuration lives in the container environment instead.

Seeding runs serially by default (SEED_PARALLEL=1). Concurrent seeding
deadlocks intermittently on PostgreSQL KEY SHARE row locks on shared parent
dcim_device rows — object disjointness says nothing about lock contention.
The escape hatch is kept for anyone who wants to retry it.

The Ansible pins are installed at run time, not the .[ansible] extra. The
conductor import chain needs ansible-core, which the unit tests stub out in
conftest.py — so a venv that passes the unit suite does not necessarily
satisfy that import. Installing the extra would also reinstall the project on
every run, replacing a developer's editable install with a wheel built from the
checkout. It is not needed for currency either: generate.py runs as
python -m from the repo root, so osism is imported from the working tree
rather than site-packages. Installing requirements.ansible.txt directly avoids
both, and is 1.4s rather than 8.9s when already satisfied.

Still nothing to run: the fixtures and goldens arrive in the next PR.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In tests/e2e/sonic_golden_test.sh the pipenv run pip install --quiet '.[ansible]' step will run on every invocation and can be both slow and mutate the developer environment unexpectedly; consider moving this into a dedicated setup step (e.g. a make target or CI job bootstrap) and failing fast if the extra is missing instead of installing it during the test run.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In tests/e2e/sonic_golden_test.sh the `pipenv run pip install --quiet '.[ansible]'` step will run on every invocation and can be both slow and mutate the developer environment unexpectedly; consider moving this into a dedicated setup step (e.g. a make target or CI job bootstrap) and failing fast if the extra is missing instead of installing it during the test run.

## Individual Comments

### Comment 1
<location path="Makefile" line_range="8-13" />
<code_context>
+# Full cycle: start the NetBox compose stack (an existing stack is reused
+# and left in place), seed, generate, compare against tests/e2e/golden/.
+sonic-e2e:
+	NETBOX_MANAGER_DIR=$(NETBOX_MANAGER_DIR) tests/e2e/sonic_golden_test.sh
+
+# Regenerate the golden files after an intentional generator change,
+# then review and commit the diff.
+sonic-e2e-regen:
+	NETBOX_MANAGER_DIR=$(NETBOX_MANAGER_DIR) tests/e2e/sonic_golden_test.sh --regenerate
+
+# Start the NetBox stack and leave it running for debugging. Export a
</code_context>
<issue_to_address>
**suggestion:** Quote NETBOX_MANAGER_DIR when exporting to avoid issues with spaces in the path

As written, these targets will fail if `NETBOX_MANAGER_DIR` contains spaces or shell-special characters because the variable expansion isn’t quoted. Please update the invocations to quote the assignment, e.g. `NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh` (or use `env NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" ...`) so directories with spaces work correctly.

Suggested implementation:

```
sonic-e2e:
	NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh

```

```
sonic-e2e-regen:
	NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh --regenerate

```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Quote NETBOX_MANAGER_DIR when exporting to avoid issues with spaces in the path

As written, these targets will fail if NETBOX_MANAGER_DIR contains spaces or shell-special characters because the variable expansion isn’t quoted. Please update the invocations to quote the assignment, e.g. NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh (or use env NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" ...) so directories with spaces work correctly.

Suggested implementation:

sonic-e2e:
	NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh

sonic-e2e-regen:
	NETBOX_MANAGER_DIR="$(NETBOX_MANAGER_DIR)" tests/e2e/sonic_golden_test.sh --regenerate

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}