tests: narrow the secrets-file existence mock

[ideaship]

The setup_password fixture patched the existence check with a flat return_value:

mocker.patch("osism.utils.rabbitmq.os.path.exists", return_value=exists)

That target reads as module-scoped but resolves to the attribute on the shared os.path module, so for the duration of the patch os.path.exists answers the same way for every caller in the process.

load_rabbitmq_password() then calls osism.tasks.conductor.utils.load_yaml_file, whose import pulls in ansible. Ansible's config manager reads ansible/config/base.yml and checks os.path.exists first, gets the mocked answer, and raises:

AnsibleError: Missing base YAML definition file (bad install?):
  .../site-packages/ansible/config/base.yml

So test_password_file_missing_returns_none fails — with a message pointing at ansible's installation rather than at the mock — whenever ansible-core happens to be importable. It passes today only because the unit-test environment has no ansible-core, which leaves the suite quietly dependent on that staying true.

This answers for the path under test and defers everything else to the real function. The test keeps asserting what it asserted; it just stops answering questions it was not asked.

Verification. Two virtualenvs differing only in whether ansible-core is installed: before, the test fails in the one that has it; after, the module passes in both.

Not required by any other change here, but it removes a tripwire under the next PR in the stack, which installs ansible for the integration job.

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• The side_effect=lambda path: ... wrapper around os.path.exists in the fixture will break if callers pass keyword-only arguments like dir_fd; consider defining it as lambda path, *args, **kwargs: (exists if path == SECRETS_PATH else real_exists(path, *args, **kwargs)) to preserve the original signature.
• The hard-coded SECRETS_PATH string in the test duplicates knowledge from the implementation; if possible, import or derive this path from the production module so tests stay aligned if the path changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `side_effect=lambda path: ...` wrapper around `os.path.exists` in the fixture will break if callers pass keyword-only arguments like `dir_fd`; consider defining it as `lambda path, *args, **kwargs: (exists if path == SECRETS_PATH else real_exists(path, *args, **kwargs))` to preserve the original signature.
- The hard-coded `SECRETS_PATH` string in the test duplicates knowledge from the implementation; if possible, import or derive this path from the production module so tests stay aligned if the path changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}