Repository navigation
Support string coercion for array-form type in OpenAPI 3.1 (runtime) - #212
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i started trying to wire up the recent
3.1changes intocommitteeand ran into an issue which this tries to resolve.problem
committeepasses query, path, and form params toopenapi_parseras rawStringsand relies oncoerce_valueto convert them. 3.1 removednullable, so a nullable param is written astype: [integer, "null"]. array-formtypepicks a type by matching the value's class, so"5"matches nothing and fails validation. every request that sends a nullable non-string param is rejected.solution
coerce_valueon, aStringthat matches no type in an array-formtypeis coerced by trying each listed non-null type in order ("5"against[integer, "null"]becomes5)Stringagainst[integer, string]stays aString)typeis already flagged in 3.0 docs byTypeArrayIn30SpecValidatorrule, since this only changes runtime behavior for an existing keyworddepends on #211 (this branch includes its commit; only the last commit is new).