Repository navigation
Support root-level $self for OpenAPI 3.2 (parse + SelfBefore32 rule) - #213
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
takayamaki
approved these changes
Oct 19, 2026
Contributor
There was a problem hiding this comment.
Sorry for the late review.
I read through this and it looks good to me.
- The parse layer and the rule follow the same pattern as the 3.1 root-level fields (
jsonSchemaDialect,webhooks). SelfBefore32is a good name, because both 3.0 and 3.1 lack this field.$selfis not used for$refresolution yet.
I think this is acceptable for now, like$dynamicRef, which is also parsed but not resolved.
The CHANGELOG says this clearly.- Ruby 4.0 is not in the CI matrix, so I ran the tests locally on Ruby 4.0.5.
They pass.
Collaborator
|
@modosc thanks for working on this, and apologies also for my delays (the last couple weeks were surprisingly hectic). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first 3.2 pr, part of #210.
$selfasself_uriSelfBefore32flags$selfin pre-3.2 docs$selfisn't used as the base uri for$refresolution yetspec/data/openapi_3_2fixture dir andintegration_3_2_spec.rb, which the rest of the 3.2 prs build on