Repository navigation
Restore live Player data and major teams from core records - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player(253802)currently raisesJSONDecodeErrorbecause the player-home endpoint returns an HTML 403 response. The constructor also fetches a player HTML page that is not used to populate its fields.Read the existing core athlete record, resolve its
majorTeamsreferences lazily, and raise non-404 HTTP errors before parsing JSON. This restoresPlayerconstruction and preservesmajor_teams, which the older #73 workaround removed. Thanks to @shsiddhant for the reproduction in #73; this PR replaces that approach because the contributor branch cannot be updated by maintainers and its Match/Summary changes conflict with the current implementation.Validation:
JSONDecodeError. After: all 5 pass against ESPN's current responses.