Repository navigation
Add working season and team navigation - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #70 proposed Team/Season navigation, but its older Match and Series calls no longer match the current package, and several new paths contain undefined names. This replacement keeps the supported feature against ESPN's current core records:
SeasonandTeamobjects, lazySeries.season_objects/current_season, complete season-backedSeries.matches, andcurrent_matchesfiltered by live status. Match lists andTeam.matchreturnMatchRefobjects so browsing a series does not launch WebKit for every scorecard. Thanks to @killuazoldyckreal for the original feature proposal in #70.The series-level event collection for series 1478874 currently has one item, while its season collection has eight. The new all-matches path uses season event references; the real returned
MatchRef(1478874, 1478914)was successfully hydrated to aMatchthrough Playwright. The oldermisc.pywrappers from #70 depend on retired match fields and are intentionally not carried over.Validation: