Repository navigation
Conversation
jmalnuit
requested review from
MehdiZaghouani,
achrafHafedh and
aottr
and
a balanced review from Copilot
November 5, 2026 16:10
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new guard blocks all saves for KYC-locked Indian-subsidiary accounts using other, including permitted edits, while directing customers to change a category selector they cannot use.
1 open issue
What changed in this PR
Extends the account’s “Other” category restrictions to every country, removing the France-only feature flag while retaining country-specific reminder wording.
Changes:
- Shows the reminder globally, with e-invoicing wording for France and its overseas departments and generic wording elsewhere.
- Removes “Other” from available category choices unless currently saved, blocks saving it, and extends company-data prompts globally.
- Adds French generic wording and tests for country coverage, category filtering, and switching behavior.
| File | Description |
|---|---|
packages/manager/modules/account/src/user/components/newAccountForm/new-account-form-controller.spec.js |
Tests global save restrictions and category-switch prompts. |
packages/manager/modules/account/src/user/components/newAccountForm/new-account-form-controller.js |
Removes country and feature-flag gates from category controls. |
packages/manager/modules/account/src/user/components/newAccountForm/new-account-form-component.constants.js |
Removes the category-control feature flag constant. |
packages/manager/modules/account/src/user/components/newAccountForm/field/new-account-form-field-component.controller.spec.js |
Adds category-list filtering tests. |
packages/manager/modules/account/src/user/components/newAccountForm/field/new-account-form-field-component.controller.js |
Filters “Other” while preserving an account’s saved value. |
packages/manager/apps/container/src/public/translations/other-category-modal/Messages_fr_FR.json |
Adds generic reminder wording in French. |
packages/manager/apps/container/src/components/other-category-modal/OtherCategoryModal.spec.tsx |
Tests wording selection and removal of feature gating. |
packages/manager/apps/container/src/components/other-category-modal/otherCategoryModal.helpers.ts |
Broadens eligibility and selects country-specific wording. |
packages/manager/apps/container/src/components/other-category-modal/otherCategoryModal.helpers.spec.ts |
Tests global eligibility and wording selection. |
packages/manager/apps/container/src/components/other-category-modal/otherCategoryModal.constants.ts |
Defines French territories and description keys. |
packages/manager/apps/container/src/components/other-category-modal/OtherCategoryModal.component.tsx |
Removes feature gating and uses country-specific descriptions. |
Review effort: Balanced
| this.isOtherCategoryControlActive() && | ||
| this.model?.legalform === USER_TYPE_OTHER | ||
| ); | ||
| return this.model?.legalform === USER_TYPE_OTHER; |
The "Autre" category can no longer be kept, whatever the country, and without a feature flag. Home page: the reminder modal is shown at every login to every account whose category is "Autre". Customers in France and its overseas departments keep the e-invoicing reform wording and its link; every other country gets the same request without it. Account edition: "Autre" is no longer offered in the category list (an account still holding it keeps seeing its current value), saving is blocked while it is selected, and switching from it to a company, association or administration prompts for the company data, in every country. Signed-off-by: jmalnuit <jonathan.malnuit@ovhcloud.com>
jmalnuit
force-pushed
the
feat/MANAGER-22512
branch
from
November 6, 2026 08:32
868fc89 to
bffd8b9
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The unconditional category check blocks every save for Indian-subsidiary accounts categorized as other when open or validated KYC locks the selector, leaving customers unable to correct the category or save unrelated changes.
Review effort: Balanced
AlexisAfonso
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Autre" account category can no longer be kept, whatever the country. The controls that existed for France only, behind the
account:fr-e-invoicing-other-categoryfeature flag, now apply everywhere, without the flag.other_category_modal_description_generickey).French translations only (
Messages_fr_FR.json), as required by the contribution rules.Ticket Reference: #MANAGER-22512