Repository navigation
Conversation
…erfaces, Models, Services) Move the existing identity code into kind folders with one public type per file. Moves and namespace updates only; no logic, route or migration changes. - IDN-01 (Platform.Identity): Application, Composition, Contracts, Domain and Infrastructure move to Services, the project root, Interfaces, Entities, Enums, Models and Persistence. The AccountDbContext migrations move to Migrations/AccountDb with unchanged content. - IDN-03 (Platform.Api): Adapters.cs is split into one file per class; the interfaces move to Interfaces/Identity, records to Models/Identity and enums to Enums/Identity. UserAccount and AccountStatus move to Platform.Identity; the identical AccountStatus enums of IDN-01 and IDN-03 become one. - Callers and tests only get the new namespaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pregled 04.11. uveče: CI je zelen i PR je tehnički mergeable, ali ovo nije isključivo refaktor IDN-02 tima 1. Menja putanje/namespaces i usklađuje modele IDN-01 (tim 18) i IDN-03 (tim 2), uključujući zajednički AccountStatus. Po pravilu da svaki tim odgovara za svoju celinu, potrebno je izričito odobrenje oba vlasnika pre merge-a. Zatražio sam review od @miticcantonija (IDN-01) i @CvijicIgor1 (IDN-03). Nakon njihovog odobrenja ponovo proveriti CI i spojiti ovaj PR metodom merge (ne squash), kako bi se zatim PR-ovi #62–#65 integrisali redom, bez preuzimanja tuđih celina. Do tada ostaje otvoren. |
|
@owlCoder oba vlasnika su odobrila #61, oba na trenutni head 0c9ed2b: IDN-03 (tim 2): CvijicIgor1 Da li je u redu da se #61 sada spoji (merge, ne squash)? Posle toga prebacujem base za #62 na main i nastavljamo redom sa #62–#65. |
|
Pregled 04.11. uveče: #61–#65 su složena IDN-02 serija (tim 1). Pozdravljamo razdvajanje od #55, ali #61 nije samo trivijalno premeštanje: diff obuhvata 60 fajlova, uključujući Platform.Identity/AccountRegistration i IDN-01 infrastrukturu koju je implementirao tim 18. Po pravilu vlasništva potrebno je pokazati da je reorganizacija IDN-01 samo mehanička i odobrena od nadležnog tima, bez promene ponašanja, ili izdvojiti tuđe fajlove. Posle novih merge-ova #61 trenutno ima i konflikt sa main. Pre spajanja početnog PR-a rešiti konflikt, potvrditi saglasnost/obuhvat i ponoviti CI. Ne spajamo #62–#65 nezavisno od #61 jer ciljaju prethodne grane. |
|
@owlCoder hvala na pregledu. Sve tri tačke su ispunjene, evo detalja. 1. Saglasnost tima 18 (IDN-01) miticcantonija je odobrio #61 danas u 19:23 na trenutni head 2. IDN-01 reorganizacija je samo mehanička #61 dira 16 postojećih IDN-01 fajlova tima 18 i iz njih izdvaja dva recorda u nove fajlove. Nijedan potpis metode, nijedna linija logike i nijedna asertacija testa nisu promenjeni. Fajlovi u kojima se menjaju samo putanja,
Fajlovi sa još jednom izmenom, takođe bez promene ponašanja:
Testovi tima 18 prolaze bez izmene u asertacijama. 3. Konflikt sa Konflikta nema. Proverio sam #61 posle svakog od šest današnjih spajanja (#69, #73, #72, #67, #71, #70) i svaki put prolazi bez konflikta. GitHub sada prikazuje PR kao mergeable. Verovatno si video privremeno stanje dok je GitHub ponovo računao spojivost posle tih spajanja. Pošto Da li je ovako u redu da se #61 spoji (merge, ne squash)? Posle toga prebacujem base za #62 na |
Component and requirement IDs
Changes
Identity code is regrouped by kind (
Entities/,Enums/,Interfaces/,Models/,Services/,Persistence/), with one public type per file. Only moves and namespace updates; no logic, route or migration content changes. This PR is separate so that the IDN-01 and IDN-03 owners can confirm it on its own.Platform.Identity/{Application,Composition,Contracts,Domain,Infrastructure}/*,Platform.Api/Endpoints/AccountEndpoints.cs,Platform.Api/Security/*AccountSnapshotandCreateAccountRequestget their own files. TheAccountDbContextmigrations move toMigrations/AccountDb/;InitialAccounts.csis unchanged, and only the entity type names in the designer and snapshot follow the new namespace.Platform.Api/Services/Identity/Adapters.cs,ChangeAccountStatus.cs, the identity interfaces,Domain/Identity/*Adapters.csis split into one file per class. The interfaces move toInterfaces/Identity/, the records toModels/Identity/and the enums toEnums/Identity/.UserAccountandAccountStatusmove toPlatform.Identity, and the two identicalAccountStatusenums (IDN-01 and IDN-03) become one.IIdentityContext,ISessionManager,AuthenticationLevelProgram.cs,LoginController,LoginAccount,SessionValidationMiddleware,Platform.Tests/Identity/*,Platform.Kt1.Tests/MainCompositionTests.csusinglines and namespaces change.Verification
dotnet build backend/SecurityLab.slnx -c Release: 0 errors, 0 warnings.Platform.Identity.Tests, which is not in the solution onmain, also builds.dotnet test backend/SecurityLab.slnx -c Release: all pass. Platform.Tests 70, Kt1 65, Audit 95, Authoring 55, Laboratories 31, RateLimiting 24, LabMetadata 7.Architecture and data flow
No change in behaviour. The folder layout is described in part 5 (docs).
Security checks and negative tests
None added. All existing IDN-03 negative tests (non-admin, self-change, invalid status, audit injection) still pass unchanged.
Dependencies
main. Next: part 2.Stack
mainReplaces #55.
🤖 Generated with Claude Code