Repository navigation
fix: Bump @grpc/grpc-js from 1.14.4 to 1.14.6 - #622
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 11 11
Lines 1841 1841
=======================================
Hits 1826 1826
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## [8.5.6](8.5.5...8.5.6) (2026-10-17) ### Bug Fixes * Bump @grpc/grpc-js from 1.14.4 to 1.14.6 ([#622](#622)) ([be3a7e8](be3a7e8))
|
🎉 This change has been released in version 8.5.6 |
Pull Request
Issue
Closes #621
The transitive dependency
@grpc/grpc-js1.14.4 is affected by two Dependabot security alerts, both with the vulnerable range>= 1.14.0, < 1.14.5:getAuthContextcan return unauthorized certificates as though they were authorizedBoth are fixed in 1.14.5.
@grpc/grpc-jsis required as^1.10.9bygoogle-gax4.4.1, which is reached viafirebase-admin13.9.0 →@google-cloud/firestore7.11.0 (an optional dependency offirebase-admin). It is not a development dependency, so it is part of the production dependency tree.Approach
Lock-file-only update via
npm update @grpc/grpc-js. This resolves 1.14.6, the latest 1.x release within the^1.10.9range ofgoogle-gax, instead of the 1.14.5 proposed in #621. 1.14.6 also addresses remaining instances of GHSA-f596-whhp-79r4.The lock file changes are limited to
@grpc/grpc-js1.14.4 → 1.14.6. Its dependency ranges (@grpc/proto-loader^0.8.0,@js-sdsl/ordered-map^4.4.2) are unchanged and remain satisfied by the installed versions.Changes
getAuthContextno longer returns unverified client certificates as though they were verified when server credentials setrequireClientCertificatetofalse(GHSA-m9gg-hp2v-232j)end()calls on completed HTTP/2 streams, unify call numbers and avoid disabled trace allocations (fix(grpc-js): avoid redundant end() calls on completed HTTP/2 streams grpc/grpc-node#3082, chore(grpc-js): unify call numbers and avoid disabled trace allocations grpc/grpc-node#3084)GRPC_NODE_DEBUG_SEND_ERROR_DETAILSenvironment variable re-enables sending them for debugging.See the 1.14.5 and 1.14.6 release notes.
Breaking Changes
None. Both are patch releases, and 1.14.6 declares the same
engines.node(>=12.10.0) and dependency ranges as 1.14.4. The changed defaults only affect applications that run@grpc/grpc-jsservers;google-gaxuses it as a client.Code Changes Required
None — the upgrade is a drop-in replacement. This adapter imports only
firebase-admin/appandfirebase-admin/messaging. FCM messaging useshttp,httpsandhttp2, andfirebase-adminloads@google-cloud/firestore(and with it@grpc/grpc-js) only when the Firestore API is accessed, which this adapter does not do.Tasks
No tasks apply; this PR only updates the lock file.
Summary by CodeRabbit