Repository navigation
Conversation
swatikumar-pplx
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom
baseURLthat contains a query string corrupts the endpoint path.buildURLconcatenates the request path onto the full base URL string, sohttps://proxy.test/api?key=xplus/searchbecomeshttps://proxy.test/api?key=x/search: the request goes to/apiwithkey=x/search.This splits the base query off before joining paths, then merges it into the request query with the lowest precedence (base, then path, then
defaultQuery, then per-requestquery). Absolute request paths are unchanged.Same issue as perplexityai/perplexity-py#139.
Validation: new
baseUrl > query parameterstest fails before the change and passes after.bazel test //...passes (8/8), plus oxlint, oxfmt and Gazelle diff checks.