Add Giscus comments system - #267
Conversation
|
Looks amazing. Perhaps comments could also be excluded for the |
|
Great minds. See #264 😁 |
|
A few sample pages:
What do you think @nohwnd? |
|
LGTM shall we just merge this? |
|
Can't, see task list in PR details. Using my fork's discussion atm. So waiting on approval and actions from @nohwnd 🙂 |
|
Ahhh 🤦🏻 |
|
How should we handle docs version changes? E.g. when we move /docs/* from v5 to v6 in the future, the existing comments made in v5-lifetime will show up on v6-pages which might be rewritten. Options:
|
|
|
||
| return ( | ||
| <Head> | ||
| <meta name="giscus:backlink" content={canonicalUrl} /> |
There was a problem hiding this comment.
Always add version here? Maybe possible to get current page version dynamically through useDocusaurusContext() to avoid hardcoding replace /docs/ with /docs/v5 for stable like we do in _redirects ?
E.g. when we move to v6 as latest, comments follow the v5 versioned docs and v6 starts fresh as it's hopefully had a rewrite or page might be removed.
|
@fflaten is this still something we want? What is left here is all admin, enable Discussions on pester/docs, make a category, install the app. But we have Discussions on pester/Pester now with 104 threads, so turning them on here too gives people two places to talk, and the ones here would be the quiet ones. The part Discussions does not give us is per-page comments, so it is a real question, not a hint to close :) If you still want it I can do the setup, otherwise let's close and reopen if it comes up again. 🤖 |
|
This idea and pester/pester discussions serve different purpose. Pester-repo generally redirects users with doc related questions. The comment system would allow easy feedback by the reader, without the cost of having to figure out where to report it. Still - fine with closing until more demand. Would probably end up being mostly support issues. |
Implements Giscus as comment system for all Docs and Commands-pages. Only index-page is currently excluded.
Comments are stored and managed as discussions in specific category in the docs-repo.
Fix #251
TODO: