fix(tia): fingerprint the configuration file in use - #1861
Open
lazerg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
The TIA fingerprint hashed
phpunit.xmlandphpunit.xml.distby name, so-c/--configurationnever reached it.pest --tiaandpest --tia -c alternate.xmlshared one graph even though the two files can declare different testsuites, excluded groups, bootstrap and source roots, and results recorded under one config were replayed under the other.compute()now takes the run's arguments and hashes whatever configuration the run actually resolves: the-cvalue when there is one (file or directory), otherwisephpunit.xmlfalling back tophpunit.xml.dist. The active config is hashed whether or not git tracks it, since an untracked localphpunit.xmlstill decides what the run does.I checked this against a scaffolded project with a seeded graph. Before,
--tia -c alternate.xmlreplayed all six cached results; after, it drops the graph and re-records, and plain--tia,-c phpunit.xmland-c ./all still replay.Happy to add a
tests/Features/Tiascenario for it if you want one.Related:
Fixes #1858.