Skip to content

RangeBearingSensor: line_style and poly_style are accepted but unused; animate the sensing beam and region #753

Open

Description

@petercorke

RangeBearingSensor.__init__ accepts line_style and poly_style and stores them as _line_style and _poly_style, but nothing reads them. They were meant to style the sensor beam and the sensing region polygon, which should be drawn and updated every time reading() is called, based on the robot's current configuration (the toolbox's MATLAB ancestor did this).

At present plot=True only displays the map and draws a line from the robot to the landmark observed (sensors.py, plot()); the range limit and the angular field of view are never shown.

Deliberately left as is for now; this is the planned future work on animating the beam.

🤖 Generated with Claude Code

Activity

  1. added
    tech-debtKnown technical debt / deferred cleanup, not a live bug
    on Oct 13, 2026
  2. added a commit that references this issue on Oct 17, 2026
    07bab37
  3. huxiaoyi-ovo commented on Oct 19, 2026

    @huxiaoyi-ovo
    Contributor

    I'd like to work on this issue. I have a focused two-file fix ready, and all fork CI checks have passed. I'll open the upstream PR for review.

  4. petercorke commented on Oct 20, 2026

    @petercorke
    OwnerAuthor

    Thanks for taking this on, it's yours, and I'd be happy to discuss what the animation might look like. There is no urgency with this, take your time.

  5. huxiaoyi-ovo commented on Oct 21, 2026

    @huxiaoyi-ovo
    Contributor

    Thanks, Peter! I've opened PR #858 for this issue: #858

    It implements the animated sensing region and landmark beam, with focused regression tests. The full CI has passed. Happy to refine the visualization based on your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtKnown technical debt / deferred cleanup, not a live bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions