Repository navigation
docs(notebooks): modernise two-link-dynamics.ipynb, including the sign convention of gravity - #853
Merged
Merged
Conversation
…n convention of gravity Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 19, 2026 08:13
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16866 16866
=====================================
Misses 16866 16866 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notebook renovation,
two-link-dynamics.ipynb. It had 3 error cells against main, and a wrong answer that raised no error; it now has none of either. No change to the toolbox.What changed
robot.dyntable()is nowrobot.dynamics().ELink,ERobot,ETS.rz()andETS.tx()are nowLink,Robot,ET.Rz()andET.tx().gravity=[0, g, 0]and said that "accelerating upward at g provides the weight force". With the current convention,gravityis the acceleration due to gravity (default[0, 0, -9.81]) andgravloadis the torque needed to hold the arm up, so the arm in this figure (y up) needs[0, -g, 0]. With[0, g, 0]the comparison against the analytic Euler-Lagrange torques printed[-19.62 -4.905] vs [19.62, 4.905]; the outputs that were saved in the notebook before chore(notebooks): generated bootstrap cell, no committed outputs, and a Pyodide install check in CI #848 showed them agreeing. Checked against the Puma 560, whose shouldergravloadatqnis +31.64, as in MATLAB. The prose now says this.After the change, the DH model, the ETS model and the analytic formulas agree for all four configurations, for the gravity and for the velocity terms. Executed headless against main (0 error cells). Not tried in a browser. Written with AI assistance (Claude Code).
🤖 Generated with Claude Code