perf: Box::pin replaced by pin! for future returned by self.client_server_exchange(context) - #1396
Open
ygxio wants to merge 1 commit into
Open
perf: Box::pin replaced by pin! for future returned by self.client_server_exchange(context)#1396ygxio wants to merge 1 commit into
self.client_server_exchange(context)#1396ygxio wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ygxio
force-pushed
the
perf/frontend-hot-path
branch
from
August 20, 2026 06:38
248b4bc to
4096472
Compare
ygxio
changed the title
self.client_server_exchange(context)
ygxio
changed the title
self.client_server_exchange(context)self.client_server_exchange(context)
Contributor
Author
|
Can i get a review here @levkk |
jkaczman
reviewed
Aug 20, 2026
jkaczman
left a comment
jkaczman
left a comment
Contributor
There was a problem hiding this comment.
I looked through the issue linked, and it doesn't look like the stats you showed correlate to these exact changes (had some other things included); could you please clarify on the exact improvements here?
Contributor
Author
|
yes as per keryl i removed the changes of DashMap and only kept the pinning changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1395