fix(query_engine): unwrap type casts in EXECUTE sharding params - #1434
Open
murex971 wants to merge 4 commits into
Open
fix(query_engine): unwrap type casts in EXECUTE sharding params#1434murex971 wants to merge 4 commits into
murex971 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
meskill
reviewed
Aug 26, 2026
Comment on lines
+126
to
+128
| 1, 'test', 1.5, true, false, NULL, B'101', now(), | ||
| 2::bigint, 'x'::text, 3.5::float8, false::bool, | ||
| NULL::int, (4::int)::bigint |
Contributor
There was a problem hiding this comment.
we should test also the cases where the actual typecast happens, like '3'::int, 1::bool, 13245-4564..::uuid it's probably fine right now while we use Format::Text, but that could the be issue if we decide to change it to binary.
also maybe we need to cover more verbose syntax CAST(value AS type) for typecast as well
Contributor
Author
There was a problem hiding this comment.
@meskill added cast coverage, extended tests.
Contributor
Author
There was a problem hiding this comment.
agreed that binary encoding would need separate handling if parameter format changes 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeCastwrappers when extracting EXECUTE arguments for sharding key routing (e.g.EXECUTE stmt(1::bigint)).