Repository navigation
Conversation
appunni-m
force-pushed
the
fix/h3-asgi-disconnect
branch
from
October 4, 2026 12:17
61536d5 to
05716d4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#383 :
Hypercorn’s HTTP/3 path did not propagate some QUIC disconnect events to the ASGI application.
When a client reset an HTTP/3 request stream, or when the underlying QUIC connection terminated, Hypercorn received the QUIC event but the corresponding ASGI application could remain unaware and continue waiting on
receive().The expected flow is:
This change routes these HTTP/3 lifecycle events through Hypercorn’s existing
StreamClosedhandling.For
StreamReset, only the affected request stream is closed.For
ConnectionTerminated, all active request streams on that QUIC connection are closed.This brings the HTTP/3 path in line with Hypercorn’s existing disconnect semantics and the ASGI HTTP disconnect event.
Reproduction
Before this change:
After this change:
Relevant specifications:
http.disconnect