Repository navigation
Conversation
--statsd-prefix used default="", so argparse always supplied an empty string and overwrote any value loaded from a config file. Use the same sentinel default as the other optional flags so file/object/toml config keeps its prefix unless the flag is passed explicitly. Fixes pgjones#382.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--statsd-prefixwas the only non-list CLI flag that used a concrete argparse default ("") instead of the sharedsentinel. After a config file/object/toml load,main()only copies CLI values when they are notsentinel, but the empty-string default always won — so astatsd_prefix = "myapp."inhypercorn_config.pywas wiped back to""on every start unless the flag was also passed on the command line.This switches
--statsd-prefixtodefault=sentinel, matching--statsd-hostand the other optional scalars. Config-file prefixes stick; an explicit--statsd-prefixstill overrides.Tested with
pytest tests/test___main__.py(18 passed), including a new case for a config-file prefix with no CLI flag and one for an explicit--statsd-prefixoverride.Fixes #382.