Skip to content

Remove confirmation dialogs for bookmark deletion - #13

Merged
pheuberger merged 1 commit into
mainfrom
claude/remove-delete-bookmark-alert-gtcvx
Feb 5, 2026
Merged

Remove confirmation dialogs for bookmark deletion#13
pheuberger merged 1 commit into
mainfrom
claude/remove-delete-bookmark-alert-gtcvx

Conversation

@pheuberger

Copy link
Copy Markdown
Owner

Summary

This PR removes the confirmation dialog flow for deleting bookmarks and replaces it with immediate deletion followed by an undo toast notification. This provides a faster, more streamlined user experience while maintaining the ability to recover deleted bookmarks.

Key Changes

  • BookmarkItem.jsx: Removed inline confirmation dialog from the delete button, now directly calls onDelete()
  • BookmarkList.jsx:
    • Removed the deleteConfirmBookmark state and associated modal component
    • Removed unused Modal and Button imports
    • Consolidated promptDeleteSelected and confirmDelete into a single deleteSelected function
    • Delete action now immediately removes the bookmark and shows an undo toast instead of prompting the user
    • Updated keyboard shortcut handler to use the new deleteSelected function

Implementation Details

  • The undo functionality is preserved through the existing toast notification system, allowing users to recover deleted bookmarks without extra confirmation steps
  • This change applies to both the delete button on individual bookmark items and the keyboard shortcut (d key)
  • Error handling remains in place for failed deletion operations

https://claude.ai/code/session_01UrVN1JphvhCWWH17fhaGVt

Delete bookmarks immediately when clicking trash icon or pressing 'd'.
A toast with undo option is shown instead of a confirmation dialog.

https://claude.ai/code/session_01UrVN1JphvhCWWH17fhaGVt
@netlify

netlify Bot commented Feb 5, 2026

Copy link
Copy Markdown

Deploy Preview for hypermarkk ready!

Name Link
🔨 Latest commit 6cbb87a
🔍 Latest deploy log https://app.netlify.com/projects/hypermarkk/deploys/698403a77b79bb00085ed919
😎 Deploy Preview https://deploy-preview-13--hypermarkk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pheuberger
pheuberger merged commit 08219ae into main Feb 5, 2026
8 of 21 checks passed
@pheuberger
pheuberger deleted the claude/remove-delete-bookmark-alert-gtcvx branch February 5, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants