Skip to content

Make socket tests robust in restricted environments #22949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NickSdot wants to merge 2 commits into
base: master
Choose a base branch
from
+36 −3
Draft

Make socket tests robust in restricted environments #22949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c648932
Avoid external DNS in addrinfo test
NickSdot Jul 28, 2026
fbad11e
Skip unavailable Unix datagram socket tests
NickSdot Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/sockets/tests/bug76839.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ sockets
if (strtolower(substr(PHP_OS, 0, 3)) === 'win') {
die('skip not valid for Windows.');
}
require __DIR__ . '/unix_dgram_skipif.inc';
?>
--FILE--
<?php
Expand All @@ -16,11 +17,11 @@ if (strtolower(substr(PHP_OS, 0, 3)) === 'win') {
// best way I could manage to reproduce this problem without modifying php itself :-/

for ($i = 0; $i < 10; $i++) {
$senderSocketPath = '/tmp/' . substr(md5(rand()), 0, rand(8, 16)) . '.sock';
$senderSocketPath = sys_get_temp_dir() . '/' . substr(md5(rand()), 0, rand(8, 16)) . '.sock';
$senderSocket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
socket_bind($senderSocket, $senderSocketPath);

$receiverSocketPath = '/tmp/' . substr(md5(rand()), 0, rand(8, 16)) . '.sock';
$receiverSocketPath = sys_get_temp_dir() . '/' . substr(md5(rand()), 0, rand(8, 16)) . '.sock';
$receiverSocket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
socket_bind($receiverSocket, $receiverSocketPath);

Expand Down
2 changes: 1 addition & 1 deletion ext/sockets/tests/gh20532.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sockets
$error_code = 0;
var_dump(socket_addrinfo_lookup(".whynot", null, [], $error_code) === false && in_array($error_code, [EAI_NONAME, EAI_FAIL], true));
var_dump(socket_addrinfo_lookup("2001:db8::1", null, ['ai_family' => AF_INET], $error_code) === false && in_array($error_code, [EAI_FAMILY, EAI_ADDRFAMILY, EAI_NONAME, EAI_NODATA]));
var_dump(socket_addrinfo_lookup("example.com", "http", ['ai_socktype' => SOCK_RAW, 'ai_flags' => 2147483647], $error_code) === false && in_array($error_code, [EAI_SOCKTYPE, EAI_SERVICE, EAI_BADFLAGS, EAI_NONAME]));
var_dump(socket_addrinfo_lookup("localhost", "http", ['ai_socktype' => SOCK_RAW, 'ai_flags' => 2147483647], $error_code) === false && in_array($error_code, [EAI_SOCKTYPE, EAI_SERVICE, EAI_BADFLAGS, EAI_NONAME]));
?>
--EXPECT--
bool(true)
Expand Down
1 change: 1 addition & 0 deletions ext/sockets/tests/socket_sendmsg_scm_rights_object.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ if (strtolower(substr(PHP_OS, 0, 3)) == 'aix') {
if (!defined('SCM_RIGHTS')) {
die('skip SCM_RIGHTS not available');
}
require __DIR__ . '/unix_dgram_skipif.inc';
?>
--FILE--
<?php
Expand Down
31 changes: 31 additions & 0 deletions ext/sockets/tests/unix_dgram_skipif.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

$socketPath = tempnam(sys_get_temp_dir(), 'php_socket_');
if ($socketPath === false) {
die('skip unable to create a temporary socket path');
}
unlink($socketPath);

$socket = socket_create(AF_UNIX, SOCK_DGRAM, 0);
if ($socket === false || !@socket_bind($socket, $socketPath)) {
$error = socket_last_error($socket !== false ? $socket : null);
if ($socket !== false) {
socket_close($socket);
}
@unlink($socketPath);

$unavailableErrors = array_filter([
defined('SOCKET_EPERM') ? SOCKET_EPERM : null,
defined('SOCKET_EACCES') ? SOCKET_EACCES : null,
defined('SOCKET_EAFNOSUPPORT') ? SOCKET_EAFNOSUPPORT : null,
defined('SOCKET_EPROTONOSUPPORT') ? SOCKET_EPROTONOSUPPORT : null,
defined('SOCKET_ESOCKTNOSUPPORT') ? SOCKET_ESOCKTNOSUPPORT : null,
defined('SOCKET_EOPNOTSUPP') ? SOCKET_EOPNOTSUPP : null,
], static fn(?int $error): bool => $error !== null);
if (in_array($error, $unavailableErrors, true)) {
die('skip unable to bind an AF_UNIX datagram socket');
}
die('unexpected AF_UNIX datagram bind failure: ' . socket_strerror($error));
}
socket_close($socket);
unlink($socketPath);
Loading