Fix redirected-test progress accounting in parallel runs - #22952
Open
NickSdot wants to merge 4 commits into
Open
Fix redirected-test progress accounting in parallel runs#22952NickSdot wants to merge 4 commits into
NickSdot wants to merge 4 commits into
Conversation
NickSdot
marked this pull request as ready for review
July 30, 2026 16:49
arnaud-lb
approved these changes
Jul 31, 2026
arnaud-lb
left a comment
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
Only nits, looks good to me otherwise.
For later, distributing redirect tests across workers may help with the long tail as well. The worker could send $IN_REDIRECT to the control process instead of running them itself.
Open
Co-authored-by: Arnaud Le Blanc <365207+arnaud-lb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #22917.
When running tests in parallel
run-tests.phpdoes not add the expanded tests to the total count. This can produce output like:After this is merged, redirected tests update the total and the current count no longer exceeds it.
TEST_PHP_FORK_SERVER=0is set that it continues to test this runner path independently when #22942 is merged.cc @arnaud-lb this is a small bugfix one