Skip to content

header: use bytes.Reader instead of bytes.Buffer - #168

Merged
pires merged 1 commit into
pires:mainfrom
rbqvq:main
Jun 30, 2026
Merged

header: use bytes.Reader instead of bytes.Buffer#168
pires merged 1 commit into
pires:mainfrom
rbqvq:main

Conversation

@rbqvq

@rbqvq rbqvq commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Use bytes.Reader instead of bytes.Buffer.

@coveralls

coveralls commented Jun 30, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 95.409%rbqvq:main into pires:main. No base build found for pires:main.

@pires

pires commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Please, share your rationale.

@rbqvq

rbqvq commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

bytes.Reader is designed for read-only data, whereas bytes.Buffer is a growable variable-sized buffer.

For better semantic clarity and lower overhead, I recommend using bytes.Reader instead of bytes.Buffer.

@pires

pires commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Thank you! Let's wait for #173 given this is a single commit that can easily be rebased and pushed just by yourself 🙇🏻‍♂️

@pires

pires commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Please, rebase and push. Thank you!

Use bytes.Reader instead of bytes.Buffer.

Signed-off-by: Coia Prant <coiaprant@gmail.com>
@pires
pires merged commit 7b13412 into pires:main Jun 30, 2026
7 checks passed
@rbqvq

rbqvq commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Thank you, Wait the next tag version 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants