fix: WriteTo empty buffer handling - #182
Merged
Merged
Conversation
pires
reviewed
Jul 30, 2026
pires
left a comment
pires
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution.
IMO we should take the buffer-clearing optimization but do not discard an empty bufio.Reader without accounting for its pending error state. Also, and pretty please, add tests that assert both memory cleanup and preservation of underlying read errors.
|
coverage: 97.337% (+0.02%) from 97.32% — mymmrac:fix/write-to-empty-buffer into pires:main |
Contributor
Author
|
@pires if PR is okay, and you don't have further comments, please merge as I don't have permissions, thanks |
Owner
|
I am looking into it with the time I have available, thank you for the ping. |
Contributor
Author
|
Of course, take your time, totally understand |
pires
reviewed
Aug 11, 2026
pires
left a comment
pires
left a comment
Owner
There was a problem hiding this comment.
Almost there, one minor question though.
This reverts commit fa7a588.
pires
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added check for buffer size and cleaning of the buffer after reading.
This PR closes #181