Repository navigation
Apply review suggestions to the plone/nick image page - #2120
Merged
Merged
Conversation
Follow-up to #2119 with the changes stevepiercy requested. Say how to pass the required variables, show the commands that remove containers and volumes, and put the environment variable option before the image name, where docker run reads it.
stevepiercy
approved these changes
Oct 31, 2026
| ``` | ||
|
|
||
| It's not possible to remove a volume that a container references, even if that container is stopped. | ||
| Remove the containers first. |
Member
There was a problem hiding this comment.
Thanks for the revision. This is much clearer to n00bs.
Member
|
OK to merge. Broken links are temporary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2119, which merged before the review from @stevepiercy finished. This applies the suggestions on
docs/install/containers/images/nick.md. Wording and punctuation suggestions went in as written, and the same serial commas were applied to two other lists on the page.Answers to the questions:
DB_PASSWORDandSECRETbe set? As environment variables, with the-eoption ofdocker run. The page now says so.docker rmanddocker volume rmsuggestion: checked on Docker 29.9.1. Both commands need names, so the page uses the containers and volumes from its example.docker rmrefuses a running container, so the example stops them first.docker volume rmalso refuses a volume that a stopped container references, which the page now says.objects.inv, so those links stay as plain URLs.One suggestion changed:
docker run plone/nick -e NICK_MODULES=apipasses-eto the image's command instead of to Docker, so the variable isn't set. The page usesdocker run -e NICK_MODULES=api plone/nick.Refs #2118