Repository navigation
Fix big-endian test expectations in frontend message tests - #272
Merged
Merged
Conversation
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
changelog - fixed
The frontend message encoder writes big-endian (network byte order) regardless of host endianness, so the wire bytes are identical on both platforms. The `ifdef bigendian` branches in the test expectations had the multi-byte integer fields reversed — they would have failed on a big-endian host. Since both branches should be identical, remove the `ifdef` entirely. Also removes one redundant `ifdef bigendian` in `_test_codecs.pony` where both branches asserted the same values. Closes #271 Closes #273
SeanTAllen
force-pushed
the
fix-bigendian-test-expectations
branch
from
October 17, 2026 21:26
107fcaf to
d0f564a
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend message encoder writes big-endian (network byte order) regardless of host endianness, so the wire bytes are identical on both platforms. The
ifdef bigendianbranches in the test expectations had the multi-byte integer fields reversed — they would have failed on a big-endian host. Since both branches should be identical, theifdefis removed entirely.Closes #271