Skip to content

fix(ci): use and fix pinned requirements - #120

Merged
dpgaspar merged 2 commits into
masterfrom
fix/requirements
Feb 9, 2026
Merged

fix(ci): use and fix pinned requirements#120
dpgaspar merged 2 commits into
masterfrom
fix/requirements

Conversation

@dpgaspar

@dpgaspar dpgaspar commented Feb 9, 2026

Copy link
Copy Markdown
Member

Summary

PR #118 updated setup.py dependencies but left requirements.txt stale. This PR fixes that oversight:

  • requirements.txt was outdated with elasticsearch==7.13.4 and missing opensearch-py entirely
  • CI was using pip install -e . which masked the issue, but local development using requirements.txt would get wrong versions

Changes

requirements.txt

  • elasticsearch==7.17.13 (was 7.13.4)
  • opensearch-py==2.8.0 (was missing)
  • sqlalchemy==2.0.29 (was 1.4.9)
  • urllib3==2.2.2 (was 1.26.5)
  • Added all transitive dependencies

setup.py

  • Bumped opensearch-py>=2.8.0 (was >=2.4.0) - required because 2.8.0 is the first version supporting urllib3 2.x

.github/workflows/ci.yml

  • Changed install order to use pinned requirements:
    pip install -r requirements.txt      # Pinned versions first
    pip install -r requirements-dev.txt  # Dev tools
    pip install -e .                     # Package in editable mode

Test plan

  • pip install -r requirements.txt succeeds without dependency conflicts
  • Linting passes (black, flake8, mypy)
  • CI passes

@dpgaspar
dpgaspar merged commit 295c274 into master Feb 9, 2026
4 checks passed
@dpgaspar
dpgaspar deleted the fix/requirements branch February 9, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants