Rename PShader to PShaderOpenGL and extract PShader interface. - #1556
Open
tychedelia wants to merge 1 commit into
Open
Rename PShader to PShaderOpenGL and extract PShader interface.#1556tychedelia wants to merge 1 commit into
tychedelia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PShaderis unlike every other P- prefixed class in that it lives exclusively in the opengl code. This is problematic for webgpu, which wants to use the same interface. In this PR, we extract the interface and renamePShadertoPShaderOpenGL.This is a breaking change that shouldn't be merged until we're ready for a new major version. Most of the methods on
PShaderOpenGLthat are GL specific are lifecycle methods not expected to be consumed by most users.