Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1894.
Remove the public
secret_key_basefallback from the production initializer. Production startup now requires an explicitSECRET_KEY_BASEthat is at least 30 characters and rejects the previously published value. Non-production environments continue to use the existing Rails secrets configuration.The Docker Compose production service now requires
SECRET_KEY_BASEinstead of silently starting with a shared key. Its error message explains how to generate one withrake secret.Deployments using the former key must rotate it; existing session cookies will become invalid. No unrelated files or test cases were added.
Validation
ruby -c config/initializers/secret_token.rbpassed.docker compose configfails whenSECRET_KEY_BASEis missing and succeeds when it is supplied.