[PULP-2041] Add PEP 592 yank support - #1282
Open
jobselko wants to merge 1 commit into
Open
Conversation
jobselko
force-pushed
the
1270
branch
3 times, most recently
from
July 24, 2026 15:05
ef91173 to
5db692e
Compare
jobselko
force-pushed
the
1270
branch
5 times, most recently
from
July 28, 2026 14:13
2e9743b to
8222c39
Compare
Member
Author
|
@otaviof fyi |
jobselko
force-pushed
the
1270
branch
2 times, most recently
from
July 30, 2026 10:12
6939fc7 to
0d0707c
Compare
github-actions
Bot
removed
multi-commit
closes pulp#1270 Assisted By: Claude Opus 4.6
jobselko
marked this pull request as ready for review
July 30, 2026 14:19
jobselko
changed the title
gerrod3
requested changes
Jul 31, 2026
|
|
||
| Once an entry is removed, packages matching it can be added to the repository again. | ||
|
|
||
| ## Package Yanking |
Contributor
There was a problem hiding this comment.
I think our new convention is for every paragraph to be on one line and allow the markdown render to put in the linebreaks.
|
|
||
| if upstream_pkg.is_yanked: | ||
| yank_marker = PackageYank( | ||
| name_normalized=pkg.name, |
Contributor
There was a problem hiding this comment.
Is pkg.name already normalized?
| return full_metadata | ||
|
|
||
|
|
||
| def latest_content_version(content_query, version): |
Contributor
There was a problem hiding this comment.
Passing in all_content is now passing in a list, so update the name to reflect.
Comment on lines
+479
to
+480
| "yanked": content.yanked, | ||
| "yanked_reason": content.yanked_reason, |
Contributor
There was a problem hiding this comment.
I think these should be getattr since we are manually adding these fields before calling this.
Comment on lines
+23
to
+27
| def yank(distro, name, version, yanked_reason=""): | ||
| url = urljoin(distro.base_url, "yank/") | ||
| return requests.post( | ||
| url, json={"name": name, "version": version, "yanked_reason": yanked_reason}, auth=YANK_AUTH | ||
| ) |
Contributor
There was a problem hiding this comment.
I don't believe we need this. We will generate the bindings for the yank/unyank endpoints. Let's use those instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1270
📜 Checklist
See: Pull Request Walkthrough