Repository navigation
Linting; drop Py 3.10; enable dependabot - #183
Conversation
From a quick check I see a lot of resource warnings. So something is probably not going as it should on all operating systems, it is just in windows where it leads to noticable failures. |
|
I removed a rogue read statement (in a close operation? No idea why it got there.) That removed quite a lot of errors but does not fix it. It seems specific to the seeking behavior that only worked on windows. I guess that since 3.14 it does not anymore. I currently have no time to investigate further. |
|
The test is only enabled on Windows and fails on Linux anyway. Should we disable seeking on Windows as well for now? |
|
Seeking in a stream is always a bit odd isn't it? Should we set pipedcompressionreader and writer to always return |
|
I agree. I checked why we added this at all: The PR that added What do you think, should I just revert PR #83? |
Yes, that makes sense. And maybe add a seekable -> false function? Or is that included by default from the IObase class? |
|
I’ve added the changes to this PR. |
|
All tests pass! Looks great. |
A couple of commits that are somewhat related:
ruff check --fixor by handCI now fails on Windows (due to its tests being run on Python 3.14), but I don’t have time to investigate now.
Edit:
tell/seekfrom_PipedCompressionProgram