PatternNodeRewriter: Allow matching variants - #2328
Draft
ricardoV94 wants to merge 1 commit into
Draft
Conversation
ricardoV94
marked this pull request as ready for review
August 9, 2026 20:34
ricardoV94
force-pushed
the
pattern_node_rewriter_equivalent_terms
branch
from
August 9, 2026 20:34
82416f0 to
657cb05
Compare
ricardoV94
marked this pull request as draft
August 9, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends PatternNodeRewriter to allow multiple variants of the pattern to match, and automates the
get_nodesfrom thetracksparameter.PyTensor will canonicalize different expressions at different passes, and will not uncanonicalize some. It never does log1p(x) -> log(1 + x). It coverts neg to mul(-1, x) in canonicalize, and back to neg at specialize. Instead of fighting order we match the expressions that we know are expected at different sages. This is not the same as writting down all variants.
Nothing fancy is done to try to reason jointly about the variants. The more we push for this functionality the more scope there will be.
For instance a rewrite that has log1p in it could be automatically expanded to match log(1 + x), and the like. Not done in this PR.
The motivation for this PR was pymc-devs/pymc#8394 (comment)