Repository navigation
Validate msgid_plural against msgstr[0] for languages with nplurals=1 - #1198
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 93.62% 93.63%
=======================================
Files 27 27
Lines 4960 4962 +2
=======================================
+ Hits 4644 4646 +2
Misses 316 316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akx
force-pushed
the
checker-one-plural
branch
from
November 4, 2026 09:19
b38f7f0 to
b6248b1
Compare
akx
enabled auto-merge (squash)
November 4, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python format checker currently only validates
msgidagainst the translation for languages with only one plural form.msgid_pluralis not checked. For example, this:does not get flagged even though it should (missing
%sin the translation).Here's a real-world example:
This translation should get flagged if it was missing the
%(count)splaceholder since it appears inmsgid_plural. it's not the case because onlymsgidis checked currently.(This translation actually produces warnings as is, because the singular does not contain
%(count)s, so perhaps an even better solution would be to only validate against the plural, but I'm not so sure about that)