Skip to content

[3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.4 (GH-150102) (GH-149477) (GH-151562) (GH-153901) - #150197

Open
zware wants to merge 5 commits into
python:3.14from
zware:backport-c62c371-3.14
Open

[3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.4 (GH-150102) (GH-149477) (GH-151562) (GH-153901)#150197
zware wants to merge 5 commits into
python:3.14from
zware:backport-c62c371-3.14

Conversation

@zware

@zware zware commented May 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit c62c371)

Keep tests passing for Tcl prior to 9.0 (GH-150102)

(cherry picked from commit ec9ce3e)

Co-Authored-By: Steve Dower steve.dower@python.org

@zware @zooba
[3.14] pythongh-124111: Update Windows build to use Tcl/Tk 9.0.3
14aa066 
(cherry picked from commit c62c371)

Keep tests passing for Tcl prior to 9.0 (pythonGH-150102)

(cherry picked from commit ec9ce3e)

Co-Authored-By: Steve Dower <steve.dower@python.org>
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2026
Open
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2026
Merged
@zware zware changed the title [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.3 (GH-149477) (GH-150102) [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.3 (GH-150102) (GH-149477) May 21, 2026
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2026
Merged
@zware

zware commented May 21, 2026

Copy link
Copy Markdown
Member Author

To be kept in draft until declared ready to merge by @zooba and @hugovk. I'd like it to make the next patch release but it's not critical to do so, setting 'deferred blocker' just to keep it on the radar.

@hugovk

hugovk commented Jun 3, 2026

Copy link
Copy Markdown
Member

Let's resolve #150836 first :)

zware and others added 2 commits June 24, 2026 10:40
@zware
Merge remote-tracking branch 'upstream/3.14' into backport-c62c371-3.14
08407ea
@jjhelmus @zware
pythongh-150836: Mount embedded Tk ZIP in _tkinter on Windows (python…
d73c6f8 
…GH-151562)

Tcl/Tk 9 may embed the Tk script library in the Tk DLL on Windows. This embedded library is not found by Tcl by default.

Mount the loaded Tk DLL as a zipfs archive before calling Tk_Init(), so Tk can find its embedded tk_library using its existing library discovery logic.

Preserve Tk_Init()'s normal path if the library is not embedded.
@zware

zware commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

gh-150836 was resolved by GH-151562, which is now included here.

@ned-deily

ned-deily commented Jul 18, 2026

Copy link
Copy Markdown
Member

As of 2026-06-26, Tcl/Tk 9.0.4 is current.

@zware

zware commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

I'll start the process of getting main and 3.15 updated to that on the Windows side.

@zware zware changed the title [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.3 (GH-150102) (GH-149477) [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.4 (GH-150102) (GH-149477) (GH-151562) Jul 18, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
Merged
@zware zware changed the title [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.4 (GH-150102) (GH-149477) (GH-151562) [3.14] gh-124111: Update Windows build to use Tcl/Tk 9.0.4 (GH-150102) (GH-149477) (GH-151562) (GH-153901) Jul 18, 2026
@bedevere-app bedevere-app Bot added the sprint label Jul 18, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
Merged
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@encukou

encukou commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What's the plan with 9.0.4 on Python 3.14?

@hugovk

hugovk commented Jul 28, 2026

Copy link
Copy Markdown
Member

To be kept in draft until declared ready to merge by @zooba and @hugovk. I'd like it to make the next patch release but it's not critical to do so, setting 'deferred blocker' just to keep it on the radar.

Let's resolve #150836 first :)

We've had it in 3.15 since b2. That issue was a bug in b2, fixed in b3, and b4 has since also come out, and it seems fine.

We already use Tck/Tk 9 in the macOS installer for both 3.14 and 3.15.

So I think we're ready to merge this for 3.14 as well.

@zware
zware marked this pull request as ready for review July 28, 2026 16:33
@zware
zware requested a review from sethmlarson as a code owner July 28, 2026 16:33
@zware
zware requested a review from a team as a code owner July 28, 2026 16:33
sethmlarson
sethmlarson approved these changes Jul 29, 2026
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBOM changes LGTM

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees

@hugovk hugovk

@zooba zooba

Labels

awaiting merge deferred-blocker sprint

Projects

Sprint
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zware @hugovk @ned-deily @encukou @sethmlarson @zooba @jjhelmus