gh-154840: Keep the color pair out of curses complexchar.attr - #154841
Open
fedonman wants to merge 1 commit into
Open
gh-154840: Keep the color pair out of curses complexchar.attr#154841fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
On a wide build getcchar() reports the packed color pair in the attributes, so attr carried it and saturated at 255, although the documentation says the pair is stored separately and is not limited to a color_pair() value. Mask A_COLOR out, as the narrow branch of the same function already does. repr() reads through the same function and is fixed with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complexchar.attrcarried the packed color pair on a wide build and saturated at 255,although the docs say the pair is stored separately and is not limited to a
color_pair()value. Mask
A_COLORin the wide branch ofcurses_cell_attr_pair(), which its narrowbranch already does.
repr()reads through the same function and is fixed with it.The test fails without the change. New in 3.16, so no NEWS entry.