gh-127172: Honor umask and default ACL when installing venv activation scripts - #154850
Open
tonghuaroot wants to merge 1 commit into
Open
gh-127172: Honor umask and default ACL when installing venv activation scripts#154850tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…ivation scripts venv wrote the activation scripts with a fixed mode copied from the packaged templates, so they ignored the process umask and any default ACL, unlike every other file venv creates. Copy only the data and let the new files inherit the umask and ACL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
venvinstalls the activation scripts (activate,activate.csh,activate.fish) by copying the packaged template's mode onto the output, sothey always end up
0644regardless of the process umask or any default ACL onthe target directory. Every other file
venvcreates (thepipwrappers, andany file written afterwards) honors the umask and ACL, so the activation scripts
are the odd ones out: on a directory with a group-writable default ACL they come
out
rw-r--r--whilepip*come outrw-rw-rw-.Activation scripts are sourced, not executed, so they need no special mode. This
drops the mode-copying in
install_scriptsso the scripts inherit the umask anddefault ACL like everything else
venvwrites.The added regression test drives the process umask, so it needs no ACL support
and runs on every POSIX platform.