Repository navigation
fix(graphics): ignore sign of scalar in expand_dims, document reversed limits - #262
Open
petercorke wants to merge 1 commit into
Open
petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
…d limits A negative scalar previously produced reversed limits (-3 -> [3,-3,...]), silently inverting the axes. A scalar is symmetric about zero, so use abs(). Document that min > max in the 2/4/6 element forms is passed through and matplotlib inverts the axis. Add test_expand_dims. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative scalar passed to
expand_dims(and soplotvol2/plotvol3/Animate) gave reversed limits, e.g.-3->[3, -3, 3, -3], silently inverting the axes. A scalar is symmetric about zero, so the sign is now ignored viaabs().For the 2/4/6 element forms no min < max check is added. Matplotlib inverts an axis when given reversed limits, so this is a useful way to flip an axis, and
expand_dimsis a pure function with no axes to callinvert_xaxis()on. The docstring now says so.Adds
test_expand_dims.🤖 Generated with Claude Code