Repository navigation
Normalize the axis in UnitQuaternion.AngVec - #266
Open
wpyaoxueros wants to merge 1 commit into
Open
wpyaoxueros wants to merge 1 commit into
wpyaoxueros wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnitQuaternion.AngVec(0.5, [1, 2, 3])currently produces a quaternion with norm greater than one and a matrix that is not the requested rotation. Normalize a nonzero-angle axis before constructing the quaternion, while preserving the documented identity result for zero angle (including a zero axis). A nonzero angle with a zero axis raisesValueError, consistently with the base angle-axis rotation constructor.Adds regression coverage for norm, angle/axis round-trip, matrix agreement, degrees, unit-axis controls, and zero-angle/zero-axis behavior.
Validation on Python 3.11:
git diff --checkpassed.AI assistance: an AI coding agent helped investigate, implement, test, and review this change. No independent human review is claimed.