Make it explicit to specify HttpClientFactoryKey and WebSocketClientFactoryKey values - #52715
Closed
christophpurrer wants to merge 1 commit into
Closed
Make it explicit to specify HttpClientFactoryKey and WebSocketClientFactoryKey values#52715christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78529932 |
christophpurrer
force-pushed
the
export-D78529932
branch
from
July 19, 2025 04:14
e9177d2 to
3065cea
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78529932 |
christophpurrer
force-pushed
the
export-D78529932
branch
2 times, most recently
from
July 19, 2025 15:41
0d2692f to
c55b54a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78529932 |
christophpurrer
force-pushed
the
export-D78529932
branch
2 times, most recently
from
July 20, 2025 20:19
974c946 to
a1c9018
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78529932 |
christophpurrer
force-pushed
the
export-D78529932
branch
from
July 20, 2025 20:24
a1c9018 to
47d7c1e
Compare
christophpurrer
force-pushed
the
export-D78529932
branch
from
July 21, 2025 04:42
47d7c1e to
c904535
Compare
…actoryKey values (react#52715) Summary: Pull Request resolved: react#52715 Changelog: [Internal] Right now we rely on compile / link time magic to detect the implementation of ``` WebSocketClientFactory getWebSocketClientFactory(); HttpClientFactory getHttpClientFactory(); ``` this actually works until it does not work anymore, see .e.g.: ``` ld.lld: error: undefined symbol: facebook::react::getHttpClientFactory() >>> referenced by ReactHost.cpp:111 (xplat/js/react-native-github/packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp:111) >>> xplat/js/react-native-github/packages/react-native/ReactCxxPlatform/react/runtime/__runtimeAndroid__/__objects__/ReactHost.cpp.pic.o:(facebook::react::ReactHost::ReactHost(facebook::react::ReactInstanceConfig, std::__ndk1::shared_ptr<facebook::react::IMountingManager>, std::__ndk1::shared_ptr<facebook::react::RunLoopObserverManager>, std::__ndk1::shared_ptr<facebook::react::ContextContainer const>, std::__ndk1::function<void (facebook::jsi::Runtime&, facebook::react::JsErrorHandler::ProcessedError const&)>, std::__ndk1::function<void (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, unsigned int)>, std::__ndk1::shared_ptr<facebook::react::IDevUIDelegate>, std::__ndk1::vector<std::__ndk1::function<std::__ndk1::shared_ptr<facebook::react::TurboModule> (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, std::__ndk1::shared_ptr<facebook::react::CallInvoker> const&)>, std::__ndk1::allocator<std::__ndk1::function<std::__ndk1::shared_ptr<facebook::react::TurboModule> (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, std::__ndk1::shared_ptr<facebook::react::CallInvoker> const&)>>>, std::__ndk1::shared_ptr<facebook::react::SurfaceDelegate>, std::__ndk1::shared_ptr<facebook::react::NativeAnimatedNodesManagerProvider>, std::__ndk1::function<void (facebook::jsi::Runtime&)>)) ld.lld: error: undefined symbol: facebook::react::getWebSocketClientFactory() >>> referenced by ReactHost.cpp:117 (xplat/js/react-native-github/packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp:117) >>> xplat/js/react-native-github/packages/react-native/ReactCxxPlatform/react/runtime/__runtimeAndroid__/__objects__/ReactHost.cpp.pic.o:(facebook::react::ReactHost::ReactHost(facebook::react::ReactInstanceConfig, std::__ndk1::shared_ptr<facebook::react::IMountingManager>, std::__ndk1::shared_ptr<facebook::react::RunLoopObserverManager>, std::__ndk1::shared_ptr<facebook::react::ContextContainer const>, std::__ndk1::function<void (facebook::jsi::Runtime&, facebook::react::JsErrorHandler::ProcessedError const&)>, std::__ndk1::function<void (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, unsigned int)>, std::__ndk1::shared_ptr<facebook::react::IDevUIDelegate>, std::__ndk1::vector<std::__ndk1::function<std::__ndk1::shared_ptr<facebook::react::TurboModule> (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, std::__ndk1::shared_ptr<facebook::react::CallInvoker> const&)>, std::__ndk1::allocator<std::__ndk1::function<std::__ndk1::shared_ptr<facebook::react::TurboModule> (std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char>> const&, std::__ndk1::shared_ptr<facebook::react::CallInvoker> const&)>>>, std::__ndk1::shared_ptr<facebook::react::SurfaceDelegate>, std::__ndk1::shared_ptr<facebook::react::NativeAnimatedNodesManagerProvider>, std::__ndk1::function<void (facebook::jsi::Runtime&)>)) clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` The change here makes it explicit and mandatory to set the specific implementations of these interfaces Reviewed By: lenaic Differential Revision: D78529932
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78529932 |
christophpurrer
force-pushed
the
export-D78529932
branch
from
July 21, 2025 04:46
c904535 to
ac44003
Compare
Contributor
|
This pull request has been merged in a0a77f7. |
Collaborator
|
This pull request was successfully merged by @christophpurrer in a0a77f7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Right now we rely on compile / link time magic to detect the implementation of
this actually works until it does not work anymore, see .e.g.:
The change here makes it explicit and mandatory to set the specific implementations of these interfaces
Differential Revision: D78529932