Repository navigation
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* pkg: Update `react-live` to v5 * pkg(website): Adopt react-live v5 cleanups react-live v5 gives its error boundary getDerivedStateFromError and stops emitting __self from sucrase, so the playground no longer needs to demote those two console messages. Drop @docusaurus/theme-live-codeblock: no docs use live code blocks, and it bundled a second copy of react-live (v4) into every page with a code block. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RCvGPJXB1cCWsppCh9yQE * internal(website): Tidy playground console demotion after react-live v5 Match React's caught-error log on its stable line (the 'component:' pattern no longer matched React 19's text), explain why a console patch is used, drop the stale translate lock key, and cover the hook with a test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RCvGPJXB1cCWsppCh9yQE * internal(website): Test console demotion against React's real caught-error log Throw inside a real error boundary instead of copying React's text, cover overlapping previews, and match the single remaining pattern directly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RCvGPJXB1cCWsppCh9yQE * internal(website): Reuse ErrorBoundary in console demotion test Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RCvGPJXB1cCWsppCh9yQE --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
* docs: Show five more playgrounds' code and preview side by side The SWAPI demo, StreamManager demo, mocking guide, client-side join and Invalidate expiry demos each have one tall open file and a short preview, so row layout puts the result next to the code instead of a screen below it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCh1jpzPu1pBp6zNSwyHFP * docs(website): Say when to use the playground's row layout Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCh1jpzPu1pBp6zNSwyHFP * docs(website): Give each row-layout exception its own reason Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCh1jpzPu1pBp6zNSwyHFP --------- Co-authored-by: Claude <noreply@anthropic.com>
* pkg: Update `temporal-polyfill` to v1 * pkg: Adapt to temporal-polyfill v1 v1 ships ESM only, so Jest now compiles temporal-polyfill and its temporal-spec/temporal-utils deps. It also defers to native Temporal itself, so the playground scope drops its manual fallback. Regenerates the playground's Temporal editor types from temporal-spec 1.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPWyKyp6ZsQTPy34USqPYA * pkg: Restore EntityMixin ts-expect-error placement tsc (TS 7, the CI typecheck) still reports the excess-property error on the key; only ts-jest's TS 6 reports it at the call, and CI runs Jest without type checking. Also drops types-only temporal-spec from Jest's transform list and notes that the polyfill now defers to native Temporal. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPWyKyp6ZsQTPy34USqPYA --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
|
Staff engineer (Cursor agent): LGTM. This is an exact revert of #4371 (the Renovate bump to Follow-up (after merge, doesn't change this PR): What I actually validated:
Only read, not exercised: I didn't run Renovate, so the grouping rule ( |
|
Folded in the description note: the Generated by Claude Code |
|
Staff engineer (Cursor agent): Re-reviewed at af59e47. Still LGTM. The new commit only changes the Follow-up (doesn't block this PR; fine to fix here or in the CLI v3 migration PR): the rename list in the description is incomplete, and my earlier comment missed this too. Our workflows also pass two camelCase inputs that v2 renamed:
Simplest fix is to say "all What I actually validated:
Inferred, not exercised: I'm going by the v2 |
|
Good catch, verified against both workflows. The Renovate note now lists all five kebab-case inputs and flags that Generated by Claude Code |
changesets/action v2 refuses to run with Changesets CLI v2, so every Release run on master has failed since #4371. Moves to CLI v3 and changelog-github v1, renames the action's inputs and has-changesets output to their v2 names (including the maintenance cut script's sed), and keeps versioning private packages, which v3 stopped by default. Renovate now groups the action's and the CLI's majors. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XT6Wh4vZ8ZJ94GaYksu7Gh
a5c2e75 to
a297575
Compare
Cuts default to the newest release tag, whose release.yml still uses changesets/action v1's publish: input. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XT6Wh4vZ8ZJ94GaYksu7Gh
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit a463364 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #4375 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 161 161
Lines 3071 3071
Branches 604 604
=======================================
Hits 3021 3021
Misses 10 10
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Staff engineer (Cursor agent): Re-reviewed at a297575, now the full CLI v3 move instead of the v1 pin. LGTM. This is the migration my earlier follow-up asked for, done in one place, and it closes the earlier notes about Follow-ups (none block this PR):
What I actually validated, and how:
Not validated: I didn't run |
…one PR Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XT6Wh4vZ8ZJ94GaYksu7Gh
|
Staff engineer (Cursor agent): Re-reviewed at 8f496f0, now that this PR does the CLI v3 migration instead of the v1 revert. LGTM. It does what my earlier follow-up asked for, in this PR: all five inputs are renamed in both workflows, the output is now The 1.0.0 to 0.19.0 change in the release plan looks right to me. CLI v3 bumps out-of-range peer dependents by patch instead of major, and with What I actually validated:
Not validated: Release and beta-release only run on push, so nothing in PR CI exercises the action v2 + CLI v3 path. The first Release run on master after merge is the real test, and it should update #4020 to 0.19.0. |
…4375) changesets/action v2 refuses to run with Changesets CLI v2, so the CLI moves to v3 (and changelog-github to v1) with it. The action's inputs and has-changesets output take their v2 names, including the maintenance cut script's sed, and private packages stay versioned, which CLI v3 stopped by default. Renovate puts every update of the action and the CLI in one PR. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XT6Wh4vZ8ZJ94GaYksu7Gh
|
Folded into master at the request of the maintainer: this change is now part of the changesets/action v2 commit (3879bdb), and master was rewritten from there (new head c9667e5). Closing as superseded. Generated by Claude Code |
Requested by Nathaniel · project thread
Before: every Release run on master fails after ~26s with
This version of the Changesets action is designed to work with Changesets CLI v3. Changesets CLI v2 is not supported(since #4371 moved tochangesets/actionv2 while we're on@changesets/cli2.31). Action v2 also renamed every input, so ours were ignored.After: we're on Changesets CLI v3 with the action's v2 inputs, so Release runs again.
Release plan change: with v2, the pending Version Packages PR (#4020) proposes
@data-client/*@1.0.0(v2 bumps peer dependents by major). v3 bumps them by patch, so the same changesets now produce0.19.0. Everything else inchangeset versionoutput (changelogs, private examples) is identical; I compared both CLIs on the current changesets.How:
@changesets/cli^3.0.3,@changesets/changelog-github^1.0.1 (the custom wrapper loads unchanged)release.yml/beta-release.yml:version/publish/commit/title/createGithubReleases→version-script/publish-script/commit-message/pr-title/create-github-releases;hasChangesetsoutput →has-changesets.changeset/config.json:privatePackages: { version: true, tag: false }keeps v2's default (v3 stops versioning private packages); schema URL → config 4.0.1scripts/maintenance/cut.sh: its sed now matchespublish-script:changesets/actionand@changesets/climajors so they land together🤖 Generated with Claude Code
https://claude.ai/code/session_01XT6Wh4vZ8ZJ94GaYksu7Gh
Note
Medium Risk
Touches npm release automation and versioning semantics (peer-dependent bump strategy); misconfiguration could block publishes or produce unexpected version numbers on the next Version Packages merge.
Overview
Upgrades Changesets CLI v2 → v3 (
@changesets/cli^3.0.3,@changesets/changelog-github^1.0.1) so Release workflows work withchangesets/actionv2, which rejects CLI v2 and renamed all inputs.CI/workflows:
release.ymlandbeta-release.ymlnow use v2 action inputs (version-script,publish-script,commit-message,pr-title,create-github-releases) instead of the old camelCase names that were being ignored. Post-publish steps gate onhas-changesets(washasChangesets), includingcreate-github-releases.mjs.Config:
.changeset/config.jsonbumps the schema to 4.0.1 and addsprivatePackages: { version: true, tag: false }to preserve v2 behavior for private workspace packages. Renovate groupschangesets/actionand@changesets/cliso they upgrade together.Maintenance:
cut.shsed matches bothpublish:andpublish-script:when retargeting release workflows on maintenance branches.Versioning note: CLI v3 bumps peer dependents by patch (not major like v2), so pending Version Packages PRs would show patch/minor bumps (e.g.
0.19.0) rather than1.0.0for the same changesets.Reviewed by Cursor Bugbot for commit a463364. Bugbot is set up for automated code reviews on this repo. Configure here.